Skip to content

ci: add frontend checks and discover all backend tests - #228

Merged
Janani-bn merged 1 commit into
mainfrom
ci/frontend-checks
Oct 22, 2026
Merged

Janani-bn merged 1 commit into
mainfrom
ci/frontend-checks

Conversation

@Janani-bn

Copy link
Copy Markdown
Owner

Summary

The existing workflow only runs backend tests. This adds separate frontend test and build checks and includes the backend file-signature tests that the current test command skips.

Changes

  • Keep the existing backend-tests check and use Node's test discovery with the current test setup.
  • Add separate frontend-tests and frontend-build jobs using Node 22 and npm ci from the repository root.
  • Discover frontend test files in tests/ instead of listing them individually.
  • Disable persisted checkout credentials. Keep read-only repository permissions and the existing pull_request and push-to-main triggers.

Validation

Checked against main at 42fd76b with clean npm ci installs on Node 22.23.3:

  • Backend: 70/70 tests pass, including the 16 previously omitted file-signature tests.
  • Frontend: 12/12 tests pass.
  • Production build passes, with the existing chunk-size warning.
  • Workflow YAML parses and git diff --check passes.

These are local results. The new workflow has not run on GitHub yet.

Scope

Partially addresses #58. This does not close it because a frontend lint check is still missing. Current main reports 233 lint problems (229 errors and 4 warnings), so lint is intentionally not added or suppressed in this PR. Those errors need a separate cleanup before adding the required lint check.

Related open PRs: #68 and #80 also add frontend CI. This overlaps their workflow changes and should be coordinated before either is merged. This PR does not include #80's saved-location changes.

No application code, dependencies or lockfiles are changed. Existing dependency advisories are outside this patch.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 03:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Janani-bn
Janani-bn merged commit 564713a into main Oct 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants