Repository navigation
ci: run frontend lint and build on pull requests - #68
tharunreddy08 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Split lint and build into independent CI jobs and checks.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds GitHub Actions CI for frontend linting and production builds on pull requests targeting main.
Changes:
- Sets up Node.js 20 and installs dependencies with
npm ci. - Runs frontend lint and build commands.
- Currently combines both checks into one job.
| File | Description |
|---|---|
.github/workflows/frontend-ci.yml |
Defines the frontend CI workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| lint-and-build: | ||
| name: Lint & Build | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "20" | ||
| cache: "npm" | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run lint | ||
| run: npm run lint | ||
|
|
||
| - name: Build | ||
| run: npm run build |
|
@tharunreddy08 This runs lint and build, but .github/workflows/frontend-ci.yml puts both under one lint-and-build job (lines 18-40). That creates one check, not the two independent checks described in the PR. Please split lint and build into separate jobs so each can pass or fail on its own. |
|
Please split lint and build into separate CI jobs so each has its own check, as #58 requires. The current root npm run lint also fails on existing errors, so this workflow would be red. Please make that check pass or narrow its scope honestly. This workflow overlaps with #80; please reconcile the branches. |
|
@tharunreddy08 This still runs lint and build in one job, so it does not give #58 the separate checks requested in the issue and earlier reviews. Root lint also currently fails on existing errors. Please split the jobs, make the lint check pass or narrow its scope clearly, and reconcile this workflow with #80. |
|
Thanks for adding frontend CI! Before merge, please split lint and build into two separate jobs so a lint failure doesn't hide build results and vice versa. |
|
Not ready to merge. The workflow still puts lint and build in the same lint-and-build job, so a lint failure prevents the build step from running and #58 does not get independent lint/build results. Main now already has CI from #228 with frontend tests and a production-build job. Please reconcile this older workflow with the existing CI, keep lint and build independently observable, and verify a fresh install passes the intended checks instead of adding a duplicate combined workflow. |
|
@tharunreddy08 is attempting to deploy a commit to the janani-bn's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi,
I received a notification from Vercel regarding the deployment of my latest
commit (129cb5c) for CivicFix PR #68.
The notification says that a member of the Vercel team needs to authorize
the deployment.
Could you please review and authorize the deployment from your Vercel team
account so that the PR preview can be generated?
The GitHub changes have already been pushed successfully.
Thank you for your support.
Best regards,
Tharun
…On Mon, 16 Nov 2026 at 14:05, vercel[bot] ***@***.***> wrote:
*vercel[bot]* left a comment (Janani-bn/CivicFix#68)
<#68 (comment)>
@tharunreddy08 <https://github.com/tharunreddy08> is attempting to deploy
a commit to the *janani-bn's projects* Team on Vercel <https://vercel.com>
.
A member of the Team first needs to authorize it
<https://vercel.com/git/authorize?team=janani-bn's%20projects&slug=janani-bns-projects&teamId=team_2Tucqe5PE2RMZmA55t3qk7I4&type=github&job=%7B%22headInfo%22%3A%7B%22sha%22%3A%22129cb5c7e27acc0a3ca8a95704af14b1cd614d6c%22%7D%2C%22id%22%3A%22QmecrgTDXtUqcx6GRWkqEs5zKkhaKX4K9EG7Zd9uJcgkBY%22%2C%22org%22%3A%22Janani-bn%22%2C%22prId%22%3A68%2C%22repo%22%3A%22CivicFix%22%7D>
.
—
Reply to this email directly, view it on GitHub
<#68?email_source=notifications&email_token=BQZGMPMESC5XZS3OHIEUZJ35ZK35NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOJRGE2DMNZVHE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6911467597>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQZGMPMRVYCGVVQIHWZWFID5ZK35NAVCNFSNUABGKJSXA33TNF2G64TZHMYTCOJXGQ4DSNZQG45US43TOVSTWNJWGAYDAOBYGA3TRILWAI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi, the Vercel deployment for PR #68 (commit 129cb5c) is awaiting
authorization due to insufficient permissions on my account.
Could an authorized Vercel team member (Member role or above) please review
and authorize the deployment?
Thanks!
On Mon, 16 Nov 2026 at 14:10, Tharun Reddy S ***@***.***>
wrote:
… Hi,
I received a notification from Vercel regarding the deployment of my
latest commit (129cb5c) for CivicFix PR #68.
The notification says that a member of the Vercel team needs to authorize
the deployment.
Could you please review and authorize the deployment from your Vercel team
account so that the PR preview can be generated?
The GitHub changes have already been pushed successfully.
Thank you for your support.
Best regards,
Tharun
On Mon, 16 Nov 2026 at 14:05, vercel[bot] ***@***.***>
wrote:
> *vercel[bot]* left a comment (Janani-bn/CivicFix#68)
> <#68 (comment)>
>
> @tharunreddy08 <https://github.com/tharunreddy08> is attempting to
> deploy a commit to the *janani-bn's projects* Team on Vercel
> <https://vercel.com>.
>
> A member of the Team first needs to authorize it
> <https://vercel.com/git/authorize?team=janani-bn's%20projects&slug=janani-bns-projects&teamId=team_2Tucqe5PE2RMZmA55t3qk7I4&type=github&job=%7B%22headInfo%22%3A%7B%22sha%22%3A%22129cb5c7e27acc0a3ca8a95704af14b1cd614d6c%22%7D%2C%22id%22%3A%22QmecrgTDXtUqcx6GRWkqEs5zKkhaKX4K9EG7Zd9uJcgkBY%22%2C%22org%22%3A%22Janani-bn%22%2C%22prId%22%3A68%2C%22repo%22%3A%22CivicFix%22%7D>
> .
>
> —
> Reply to this email directly, view it on GitHub
> <#68?email_source=notifications&email_token=BQZGMPMESC5XZS3OHIEUZJ35ZK35NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOJRGE2DMNZVHE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6911467597>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BQZGMPMRVYCGVVQIHWZWFID5ZK35NAVCNFSNUABGKJSXA33TNF2G64TZHMYTCOJXGQ4DSNZQG45US43TOVSTWNJWGAYDAOBYGA3TRILWAI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@tharunreddy08 Thanks for the update. The separate frontend-lint job addresses the earlier combined-check concern. The Vercel preview is still waiting for team authorization, but that is separate from the lint/build checks required by #58, which should run without project secrets. I don't see any GitHub Actions results for 129cb5c yet, so I can't confirm this is ready to merge. Please also update the PR description to match the new workflow: Node.js 22 and |
DescriptionUpdated the GitHub Actions CI workflow to provide independent and observable checks for backend tests, frontend tests, frontend linting, and frontend build. Changes Made
Validation
Related IssueCloses #58 |
|
Description
Updated the GitHub Actions CI workflow to provide independent and
observable checks for backend tests, frontend tests, frontend linting, and
frontend build.
Changes Made
-
Maintained separate jobs for backend tests and frontend tests.
-
Added an independent frontend-build job.
-
Added an independent frontend-lint job.
-
Removed the duplicate frontend-ci.yml workflow to avoid redundant CI
execution.
-
Configured Node.js 22 for frontend and backend workflows.
-
Used npm ci for dependency installation.
-
Configured frontend linting with npx eslint src.
-
Ensured lint and build run independently without job dependencies.
Validation
-
Backend tests: 92 passed.
-
Frontend tests: 41 passed.
-
Frontend build: Successful.
-
Frontend lint: Executed locally; existing ESLint errors and warnings
remain to be reviewed.
Related Issue
Closes #58
…On Mon, 16 Nov 2026 at 14:29, Janani ***@***.***> wrote:
*Janani-bn* left a comment (Janani-bn/CivicFix#68)
<#68 (comment)>
@tharunreddy08 <https://github.com/tharunreddy08> Thanks for the update.
The separate frontend-lint job addresses the earlier combined-check
concern. The Vercel preview is still waiting for team authorization, but
that is separate from the lint/build checks required by #58
<#58>, which should run
without project secrets. I don't see any GitHub Actions results for
129cb5c
<129cb5c>
yet, so I can't confirm this is ready to merge. Please also update the PR
description to match the new workflow: Node.js 22 and npx eslint src.
—
Reply to this email directly, view it on GitHub
<#68?email_source=notifications&email_token=BQZGMPMQM24WO77FMIOGU6L5ZK6XZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOJRGE4TINBWGI4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6911944628>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQZGMPLRRM5H362ZDKV5BZ35ZK6XZAVCNFSNUABGKJSXA33TNF2G64TZHMYTCOJXGQ4DSNZQG45US43TOVSTWNJWGAYDAOBYGA3TRILWAI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi,
I hope you're doing well.
I wanted to follow up on my CivicFix contribution (PR #68) and check if
there are any updates regarding the review or the GitHub Actions CI checks.
I've updated the workflow with separate frontend lint and build jobs and
updated the PR description as requested.
Please let me know if any further changes or actions are needed from my
side.
Thank you for your time and feedback.
Best regards,
Tharun
On Mon, 16 Nov 2026 at 14:35, Tharun Reddy S ***@***.***>
wrote:
… Description
Updated the GitHub Actions CI workflow to provide independent and
observable checks for backend tests, frontend tests, frontend linting, and
frontend build.
Changes Made
-
Maintained separate jobs for backend tests and frontend tests.
-
Added an independent frontend-build job.
-
Added an independent frontend-lint job.
-
Removed the duplicate frontend-ci.yml workflow to avoid redundant CI
execution.
-
Configured Node.js 22 for frontend and backend workflows.
-
Used npm ci for dependency installation.
-
Configured frontend linting with npx eslint src.
-
Ensured lint and build run independently without job dependencies.
Validation
-
Backend tests: 92 passed.
-
Frontend tests: 41 passed.
-
Frontend build: Successful.
-
Frontend lint: Executed locally; existing ESLint errors and warnings
remain to be reviewed.
Related Issue
Closes #58
On Mon, 16 Nov 2026 at 14:29, Janani ***@***.***> wrote:
> *Janani-bn* left a comment (Janani-bn/CivicFix#68)
> <#68 (comment)>
>
> @tharunreddy08 <https://github.com/tharunreddy08> Thanks for the update.
> The separate frontend-lint job addresses the earlier combined-check
> concern. The Vercel preview is still waiting for team authorization, but
> that is separate from the lint/build checks required by #58
> <#58>, which should run
> without project secrets. I don't see any GitHub Actions results for
> 129cb5c
> <129cb5c>
> yet, so I can't confirm this is ready to merge. Please also update the PR
> description to match the new workflow: Node.js 22 and npx eslint src.
>
> —
> Reply to this email directly, view it on GitHub
> <#68?email_source=notifications&email_token=BQZGMPMQM24WO77FMIOGU6L5ZK6XZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOJRGE4TINBWGI4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6911944628>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BQZGMPLRRM5H362ZDKV5BZ35ZK6XZAVCNFSNUABGKJSXA33TNF2G64TZHMYTCOJXGQ4DSNZQG45US43TOVSTWNJWGAYDAOBYGA3TRILWAI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
tharunreddy08
left a comment
There was a problem hiding this comment.
Hi, I've checked the PR status. The Vercel deployment is currently blocked because authorization is required, and there is one unresolved comment.
Could you please authorize the Vercel deployment and let me know if any further changes are required from my side?
Thank you!

Summary
Fixes #58 — Run frontend lint and build on pull requests.
Changes
main.npm ci.Testing
The workflow runs:
Closes #58