Repository navigation
Fix saved location and add frontend CI - #80
tharunreddy08 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Coordinate validation still accepts certain malformed non-numeric values.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes saved-location handling for zero-valued coordinates and adds frontend lint/build CI checks.
Changes:
- Updates coordinate validation to accept valid
0values. - Adds separate frontend lint and build jobs.
| File | Description |
|---|---|
src/components/NearbyComplaints.jsx |
Validates saved coordinates, including zero values. |
.github/workflows/frontend-ci.yml |
Runs frontend lint and build checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@tharunreddy08 The coordinate fix now meets #41, but the new lint job still fails on the current code (125 errors), so #58 cannot give a passing CI check on a clean PR. Please make that job pass or narrow its scope clearly. This also overlaps #67, #68 and the newer #87, so please reconcile the duplicate changes before PR |
|
This mixes two changes - the saved-location fix and frontend CI. Please split them into separate PRs so each can be reviewed on its own; the CI part also overlaps with #68. |
|
Not ready to merge: this head conflicts with current main (b7ce27b) in |

Description
This pull request fixes issues #41 and #58 in CivicFix.
Fixes #41 — Saved location ignored when latitude or longitude is
0Updated the saved-location coordinate validation in
NearbyComplaints.jsxto correctly handle valid0latitude or longitude values instead of treating them as missing.Fixes #58 — Run frontend lint and build on pull requests
Added a GitHub Actions workflow at
.github/workflows/frontend-ci.ymlto automatically run frontend checks when a pull request targets themainbranch.The workflow runs:
npm cinpm run lintnpm run buildValidation
Verified the frontend using: