This repository was archived by the owner on Mar 18, 2026. It is now read-only.
Feature/bookmark plans#9
Closed
Janooski wants to merge 25 commits into
Closed
Conversation
pheonix8
reviewed
May 20, 2025
pheonix8
reviewed
May 27, 2025
Collaborator
pheonix8
left a comment
pheonix8
left a comment
There was a problem hiding this comment.
Some small changes are missing, else looking good
pheonix8
approved these changes
May 28, 2025
Collaborator
pheonix8
left a comment
pheonix8
left a comment
There was a problem hiding this comment.
Looks good. Please wait with the merge until the following things are done:
- Janooski/web#7 is merged
- Janooski/web#9 is ready for system testing.
Owner
Author
|
Systems tests kept failing, even after rebase of the main branch. https://github.com/Janooski/web/actions/runs/15375670000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As feature/multiple-plan-versions is merged, after code review this PR is ready too.