Nether API related fixes#23
Open
jbredwards wants to merge 1 commit into
Open
Conversation
- Declare mod dependencies. - Only use the Nether API code within the "api" package, since anything else is prone to changing between updates. - Remove re-implementations of Nether API features (to avoid confusing other mod devs that expect Nether API code to be ran!): - Ash wastelands biome music now uses the music handler provided by Nether API. - Don't override Nether API world provider, fixing parity issues with Nether API and jbredwards/Nether-API#37. - Remove chunk generator, fixing parity issues with Nether API. More testing should probably be done before releasing this, to make sure things still behave as intended!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More testing should probably be done before releasing this, to make sure things still behave as intended!