Display column comments in HTML tooltips - #51
Merged
Merged
Conversation
zamax14
marked this pull request as ready for review
June 29, 2026 08:06
zamax14
marked this pull request as draft
June 29, 2026 08:18
zamax14
marked this pull request as ready for review
June 29, 2026 08:21
Comment on lines
-368
to
375
| }}, g); | ||
| }}; | ||
| if (field.comment) {{ | ||
| nameAttrs.title = field.comment; | ||
| kindAttrs.title = field.comment; | ||
| }} | ||
| el('text', nameAttrs, g); | ||
| el('text', kindAttrs, g); | ||
| }} |
Owner
There was a problem hiding this comment.
The column-comment tooltip doesn't work in the browser. The comment is assigned as title, and since el() does setAttribute('title', ...) on an SVG , it ends up as a title attribute. In SVG, the native tooltip is NOT produced by the title attribute it requires a child <title> element, so Chrome shows nothing on hover.
JoseVelazcoH
requested changes
Jun 30, 2026
…ments # Conflicts: # tests/conftest.py # tests/test_introspect.py
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Column(comment=...)during introspection.titleattributes in the browser so users can inspect them on hover.Tests
.venv/bin/python -m pytest tests/test_introspect.py tests/test_html_renderer.py.venv/bin/python -m pytestDocumentation