Add prepare-stage timing logs to diagnose WindInterpolation bottlenecks - #8
Draft
KULcoder wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
prepare()spends time for theWindInterpolationModel, with suspicion around file I/O.xr.open_mfdataset, spline coefficient computation in_splrep/scipy.make_interp_spline(including any daskmap_blocksactivity), output writes viaxr.save_mfdataset, SHA256 hashing of outputs, and metadata dump.Description
BaseModel.preparewithtime.perf_counter()measurements andlogger.infomessages that report elapsed time per year/month for:open_mfdataset,_prepare_dataset,result.register, andresult.dump.import timeand placed timers around the with-block that opens the reference files, the call to_prepare_dataset, theresult.registercall, and the finalresult.dumpstep.Testing
python -m compileall src/geodata/model/_base.pyand the file compiled successfully.Codex Task