Skip to content

Add prepare-stage timing logs to diagnose WindInterpolation bottlenecks #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KULcoder wants to merge 1 commit into
base: data-pvlib-integration
Choose a base branch
from
Draft

Add prepare-stage timing logs to diagnose WindInterpolation bottlenecks #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion src/geodata/model/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import os
import platform
import shutil
import time
from typing import Optional

import xarray as xr
Expand Down Expand Up @@ -338,6 +339,7 @@ def prepare(self, force: bool = False):

engine = _get_xr_engine()
parallel = _should_use_parallel_reading()
io_start = time.perf_counter()
logger.info(
f"prepare: Opening {len(result.ref_files)} files with engine={engine}, parallel={parallel}"
)
Expand All @@ -346,10 +348,42 @@ def prepare(self, force: bool = False):
engine=engine,
parallel=parallel,
) as ds:
open_elapsed = time.perf_counter() - io_start
logger.info(
"prepare: open_mfdataset for %04d-%02d completed in %.2fs",
result.year,
result.month,
open_elapsed,
)

compute_start = time.perf_counter()
prepared_ds = self._prepare_dataset(ds)
compute_elapsed = time.perf_counter() - compute_start
logger.info(
"prepare: _prepare_dataset for %04d-%02d completed in %.2fs",
result.year,
result.month,
compute_elapsed,
)

register_start = time.perf_counter()
result.register(prepared_ds)

register_elapsed = time.perf_counter() - register_start
logger.info(
"prepare: register for %04d-%02d completed in %.2fs",
result.year,
result.month,
register_elapsed,
)

dump_start = time.perf_counter()
result.dump()
logger.info(
"prepare: dump metadata for %04d-%02d completed in %.2fs",
result.year,
result.month,
time.perf_counter() - dump_start,
)
logger.info("Model prepared successfully.")

@abc.abstractmethod
Expand Down