Skip to content

ci: CodeQL fixes, clang-tidy, clang-format, PR template#50

Merged
KaiUR merged 6 commits into
mainfrom
develop
Jun 2, 2026
Merged

ci: CodeQL fixes, clang-tidy, clang-format, PR template#50
KaiUR merged 6 commits into
mainfrom
develop

Conversation

@KaiUR
Copy link
Copy Markdown
Owner

@KaiUR KaiUR commented Jun 2, 2026

Summary

  • Fix 3 CodeQL alerts (tautological comparison, variable shadowing ×2)
  • Add clang-tidy workflow + .clang-tidy config (bugprone, cert, security checks incl. unsafe buffer handling)
  • Add clang-format workflow + .clang-format config + apply baseline formatting to all source files
  • Add PR template

Test plan

  • Build passes
  • CodeQL scan clean (remaining alerts dismissed as false positives)
  • clang-format baseline applied and committed

KaiUR and others added 6 commits June 2, 2026 23:06
- meta.c: remove redundant cur < DESC_MAX (always true after early return)
- settings.c: rename local msg[] to warn[]/dup_msg[] to stop shadowing msg param
- sources.c: rename local msg[] to confirm[] to stop shadowing msg param

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling
to flag use of strcpy/strcat/sprintf/memcpy/gets etc. as CI failures,
enforcing the 'Memory-safe functions only' rule from the developer guide.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
One-time reformatting pass to establish a clean baseline that the
format.yml CI workflow can enforce going forward.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@KaiUR KaiUR merged commit b37f6ef into main Jun 2, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant