Repository navigation
feat: keep AlphaPulldown's own files in alphapulldown/ and debug/ - #664
Merged
Merged
Conversation
A fold's directory now holds AlphaFold's outputs at the top, and what AlphaPulldown adds for itself in two subdirectories: - alphapulldown/: the fold record (prediction.json, was alphapulldown_prediction.json), the inference-kernel record (inference_kernels.json), and the copied feature metadata (feature_metadata/). - debug/: what --debug_msas and --debug_templates write; templates in debug/templates/ (AF2's was templates_debug/). AF3 wrote its template debug files, and a note on any template that failed to convert, into the current working directory; they now go beside the fold. AF2 and AF3 share one kernel-record writer (atomic, never failing a finished prediction). Folds from 2.10 keep working: a top-level inference_kernels.json is moved into alphapulldown/ on its next entry, and ModelCIF conversion and AF3 ModelCIF metadata still read feature metadata copied to the top. AlphaFold's own files, completed_fold.txt (the workflow's) and what AlphaJudge reads stay where they were. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fold's output directory had grown a scatter of AlphaPulldown's own JSON files next to AlphaFold's outputs. They now go in two subdirectories, and AlphaFold's own files stay where AlphaFold, AlphaJudge and users expect them.
--debug_templatesmmCIFs, and a note on any template that failed to convert, into the current working directory. They now go to the fold'sdebug/templates/.prediction/inference_kernels.py). It writes atomically and never fails a finished prediction; AF2's used to write in place and could raise.inference_kernels.jsonis moved intoalphapulldown/on its next entry.alphapulldown_prediction.jsonwas never released, so it needs no compatibility.Verification
mainwrites are byte-identical at their new locations (76 moved). The only new files are the 3,317 AF3 template debug mmCIFs that used to land in the working directory.main, plus 5 new tests (layout, kernel-record migration, metadata lookup in both places). AF2 image: 979 passed. AF3 image: 1049 passed.mainonce this round is merged.🤖 Generated with Claude Code