Repository navigation
test(packets): verify observation hex after rerenders - #2105
Merged
Merged
Conversation
Contributor
Author
|
CI status at I reproduced identical failures with this PR's fixture bytes restored to their old values. Paths remain 22px tall; an oversized empty Expand column squeezes Details and grows whole rows. The unchanged test passes 6/6 with #2090's three frontend assets at Keeping this draft pending the layout fix, then final CI and independent review. The assertion remains intact. |
Collaborator
Contributor
Author
n30nex
force-pushed
the
codex/observation-hex-test
branch
from
October 3, 2026 16:35
9135520 to
ca553e4
Compare
n30nex
marked this pull request as ready for review
October 3, 2026 17:31
Contributor
Author
|
Review feedback addressed (commit
Ready for maintainer review. |
efiten
pushed a commit
that referenced
this pull request
Oct 3, 2026
Red commit: `ac60248` ([two intended label failures](https://github.com/Kpa-clawbot/CoreScope/actions/runs/37137429333)). Original grouping red: `767da9b` ([CI](https://github.com/Kpa-clawbot/CoreScope/actions/runs/36353796690)). Fixes #2073. #2088 is merged. Rebased onto master `415362c`; all eight patches are unchanged, including the test-first history. Recent Adverts groups the bounded sample by authoritative `advert_kind`: Flood, Mixed flood / direct (empty path), Direct (empty path), and Other / unknown. Missing evidence stays unknown. Each advert appears once, preserving reception metadata, order, packet links, counts and origin/history explanations. Wording describes observed remaining paths without inferring original send mode or RF distance. Validation at `6317baf`: - All 185 standalone suites passed; syntax, XSS and lint passed (zero errors, 92 existing warnings). - Browser verified: `http://127.0.0.1:51827` (temporary Go fixture server, now stopped), desktop pane/full view and mobile. Mixed evidence, exact links and caveats checked again after pushing. - The expanded fixture exposes the existing #2104 failure in the unmodified core harness. Supplemental integration with #2105's exact test correction passes 135 checks, with three existing skips. Both PRs remain separate. - [Fresh green CI](https://github.com/Kpa-clawbot/CoreScope/actions/runs/37138366726) passed; three independent automated reviews found no must-fix issues. E2E assertion added: `tests/e2e/test-e2e-playwright.js:142`. Grouping is O(n) over the existing 20-advert sample. No new requests, settings, colors or dependencies. ## Preflight overrides External OpenClaw runner/profile unavailable; repository checks and actual local Chromium were used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red commit:
ca553e4(expected assertion failure).Fixes #2104.
The observation hex test now opens the existing grouped fixture directly, selects A → B → A with stable-ID locators, and asserts the selected ID and exact raw bytes after each render. Missing fixture data fails explicitly. Distinct observation frames are seeded after schema migration; this test's fixed sleeps and silent skips are removed.
Rebased onto master
415362cafter #2090 merged. Both patches are unchanged. The previous #1122 layout blocker now passes against the actual current server and assets.Validation at
5db8017:Only test code and fixture setup change; no configuration/customizer implications.
Preflight overrides
External OpenClaw runner/profile unavailable; repository checks and actual local Chromium were used.