Skip to content

test(packets): verify observation hex after rerenders - #2105

Merged
efiten merged 2 commits into
Kpa-clawbot:masterfrom
n30nex:codex/observation-hex-test
Oct 3, 2026
Merged

efiten merged 2 commits into
Kpa-clawbot:masterfrom
n30nex:codex/observation-hex-test

Conversation

@n30nex

@n30nex n30nex commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Red commit: ca553e4 (expected assertion failure).

Fixes #2104.

The observation hex test now opens the existing grouped fixture directly, selects A → B → A with stable-ID locators, and asserts the selected ID and exact raw bytes after each render. Missing fixture data fails explicitly. Distinct observation frames are seeded after schema migration; this test's fixed sleeps and silent skips are removed.

Rebased onto master 415362c after #2090 merged. Both patches are unchanged. The previous #1122 layout blocker now passes against the actual current server and assets.

Validation at 5db8017:

Only test code and fixture setup change; no configuration/customizer implications.

Preflight overrides

External OpenClaw runner/profile unavailable; repository checks and actual local Chromium were used.

@n30nex

n30nex commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

CI status at 9135520: the new observation regression passed. The later #1122 row-height test failed on existing table sizing.

I reproduced identical failures with this PR's fixture bytes restored to their old values. Paths remain 22px tall; an oversized empty Expand column squeezes Details and grows whole rows.

The unchanged test passes 6/6 with #2090's three frontend assets at 541bde6, on the same API/data (maximum row 211→41px). That verifies this blocker only.

Keeping this draft pending the layout fix, then final CI and independent review. The assertion remains intact.

@efiten

efiten commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

@n30nex #2090 is merged (a4a447ac), so the packets layout fix this PR was waiting on is now in master. Could you rebase onto current master? The #1122 row-height test should pass after that, and then this can come out of draft for final CI and review.

@n30nex

n30nex commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks — I’ve confirmed #2090 is in current master. I’m rebasing this branch now, then rerunning the observation regression, #1122 layout check and the relevant browser suites. I’ll preserve the test-first history and keep it draft until fresh CI and independent review are complete.

@n30nex
n30nex force-pushed the codex/observation-hex-test branch from 9135520 to ca553e4 Compare October 3, 2026 16:35
@n30nex
n30nex marked this pull request as ready for review October 3, 2026 17:31
@n30nex

n30nex commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Review feedback addressed (commit 5db8017):

  1. Rebased onto 415362c after fix(packets): pack short columns, one expand arrow, Full Names toggle #2090; both patches remain unchanged.
  2. The bug(packets): filter UX disaster — help panel overlaps table, toolbar chaotic, path chips spill rows #1122 layout check now passes. All 185 standalone suites, the core browser suite (133 passed, three existing skips), and related filter/group checks passed locally.
  3. Fresh CI passed Go, full Playwright and Docker. The rebased red checkpoint still fails on the intended detached-row assertion.
  4. Three independent automated reviews found no must-fix issues.

Ready for maintainer review.

@efiten
efiten merged commit 99a326a into Kpa-clawbot:master Oct 3, 2026
8 checks passed
efiten pushed a commit that referenced this pull request Oct 3, 2026
Red commit: `ac60248` ([two intended label
failures](https://github.com/Kpa-clawbot/CoreScope/actions/runs/37137429333)).
Original grouping red: `767da9b`
([CI](https://github.com/Kpa-clawbot/CoreScope/actions/runs/36353796690)).

Fixes #2073.

#2088 is merged. Rebased onto master `415362c`; all eight patches are
unchanged, including the test-first history.

Recent Adverts groups the bounded sample by authoritative `advert_kind`:
Flood, Mixed flood / direct (empty path), Direct (empty path), and Other
/ unknown. Missing evidence stays unknown. Each advert appears once,
preserving reception metadata, order, packet links, counts and
origin/history explanations. Wording describes observed remaining paths
without inferring original send mode or RF distance.

Validation at `6317baf`:
- All 185 standalone suites passed; syntax, XSS and lint passed (zero
errors, 92 existing warnings).
- Browser verified: `http://127.0.0.1:51827` (temporary Go fixture
server, now stopped), desktop pane/full view and mobile. Mixed evidence,
exact links and caveats checked again after pushing.
- The expanded fixture exposes the existing #2104 failure in the
unmodified core harness. Supplemental integration with #2105's exact
test correction passes 135 checks, with three existing skips. Both PRs
remain separate.
- [Fresh green
CI](https://github.com/Kpa-clawbot/CoreScope/actions/runs/37138366726)
passed; three independent automated reviews found no must-fix issues.

E2E assertion added: `tests/e2e/test-e2e-playwright.js:142`.

Grouping is O(n) over the existing 20-advert sample. No new requests,
settings, colors or dependencies.

## Preflight overrides
External OpenClaw runner/profile unavailable; repository checks and
actual local Chromium were used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(packets): observation hex test clicks stale DOM handles

2 participants