Repository navigation
feat(i18n): translate GUI search and library actions - #953
Merged
Merged
Conversation
Translate browser search, discovery, playlist sync, library menus, sorting and radio actions into both Chinese scripts. Keep action payloads and command/config tokens unchanged.
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Discovery, search, and commands src/core/i18n/gui/zh_hans.rs, src/core/i18n/gui/zh_hant.rs |
Both locale tables add general labels and translations for discovery, search, command prompts, and command descriptions. |
Search results and library actions src/core/i18n/gui/zh_hans.rs, src/core/i18n/gui/zh_hant.rs |
Both locale tables add version and search-result labels, track options, library actions, and album and artist sorting labels. |
History, deletion, and sorting src/core/i18n/gui/zh_hans.rs, src/core/i18n/gui/zh_hant.rs |
Both locale tables add song radio, listening history, deletion prompts, and sorting options. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related issues
- Issue 872: This work adds Simplified and Traditional Chinese GUI translations, matching the issue’s contributor-credit context for translation.
Possibly related PRs
- LargeModGames/spotatui#939: This PR adds more translations to the same Simplified and Traditional Chinese GUI tables.
- LargeModGames/spotatui#937: This PR updates release language information for Chinese browser-GUI availability.
- LargeModGames/spotatui#907: This PR adds GUI library-filter strings that this change translates.
Merge Risk: 
80807
-
No actionable merge-blocking risk is evident in the translated GUI strings.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title uses the allowed conventional-commit prefix feat(i18n):and clearly describes the main translation changes for GUI search and library actions. The subject is concise and imperative.Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
LargeModGames
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The eleventh Chinese translation PR (refs #726), the second of the GUI table: the browser frontend's search and command bar, Discover, the library menus and sorting, playlist sync, radio actions, the update notices and the keyboard hints, in Simplified Chinese (
zh-Hans) and Traditional Chinese with Taiwan wording (zh-Hant).src/core/i18n/gui/zh_hans.rs,zh_hant.rs: 170 more strings, so 384 of the GUI table's 510 now have both translations...ENand come in the next PR.enter,tab,shift+enter,J K,[ ]) and command tokens stay as typed. Quotation marks follow each script's existing entries: “…” in Simplified, 「…」 in Traditional.gui/src/bindings/strings.jsonis regenerated.English is unchanged.
Testing
macOS (aarch64), on top of
fb8fbbb0:cargo fmt --all --check: clean.cargo clippy --locked -- -D warnings: clean on slim (telemetry,tui) and default.cargo test --locked: slim 1789 passed; default pluslocal-files,subsonic2393 passed, 21 ignored; the gui feature set with the five sources 2202 passed, 30 ignored.gui/:npm test540 passed (61 files);npm run typecheckandnpm run lintclean.Not run: the Linux-only
all-sourcesleg (PipeWire), which CI covers.Additional notes
A native-speaker review of the wording is welcome; any fix is a one-line change in the table.
Summary by CodeRabbit