fix(tooling): Make generated Astro labs pass checks - #30
Merged
Merged
Conversation
Keep the starter page in a formatted Astro template. A new lab then passes the repository formatting gate without a manual cleanup step. Co-authored-by: Codex <noreply@openai.com>
Preview deployments
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
New Astro labs pass the formatting gate immediately after creation.
Overview of Changes
The generated starter page used tightly packed markup. Prettier's Astro plugin changed it again on a second pass, so
pnpm lab create --applyproduced a project that failedpnpm check. The page now comes from a readable.astrotemplate checked by the repository formatter. The generator test confirms that the template is the file included in new site projects.Follow-ups
None.
Verification
An isolated lab passed
pnpm check, production build, desktop and mobile browser tests, and the offline archive suite. The pre-pushpnpm checkalso passed after the temporary lab was removed.