Skip to content

fix(tooling): Make generated Astro labs pass checks #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillieCubed merged 1 commit into from
Sep 24, 2026
+35 −3
Merged

fix(tooling): Make generated Astro labs pass checks #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/labs-cli/src/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ import { readCreateInput } from './create-input.js';
import { writeProject } from './create-write.js';
import { archiveTemplate } from './create-archive.js';

const siteIndexTemplate = new URL(
'../templates/generated-project/site-index.astro',
import.meta.url,
);

function assertAvailableSlug(root: string, slug: string): void {
const reserved = [
path.join(root, 'apps', slug),
Expand Down Expand Up @@ -159,8 +164,7 @@ export async function createLab(root: string, args: string[]): Promise<void> {
if (site) {
files['astro.config.ts'] =
`import { defineConfig } from 'astro/config';\nimport tailwindcss from '@tailwindcss/vite';\nexport default defineConfig({site:'https://labs.lasvegasfortransit.org',base:'${base}',build:{format:'directory'},vite:{plugins:[tailwindcss()]}});\n`;
files['src/pages/index.astro'] =
`---\nimport '../styles.css';\nimport LabLifecycleNotice from '@lvbt/ui/astro/lifecycle-notice';\nimport manifest from '../../lab.config';\n---\n<html lang="en"><head><meta charset="utf-8" /><meta name="viewport" content="width=device-width" /><meta name="robots" content="noindex" /><title>{manifest.title}</title></head><body><main><LabLifecycleNotice manifest={manifest} /><h1>{manifest.title}</h1><p>{manifest.summary}</p></main></body></html>\n`;
files['src/pages/index.astro'] = await readFile(siteIndexTemplate, 'utf8');
} else {
files['vite.config.ts'] =
`import { defineConfig } from 'vite';\nimport react from '@vitejs/plugin-react';\nimport tailwindcss from '@tailwindcss/vite';\nexport default defineConfig({base:'${base}',plugins:[react(),tailwindcss()]});\n`;
Expand Down
21 changes: 21 additions & 0 deletions packages/labs-cli/templates/generated-project/site-index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
import '../styles.css';
import LabLifecycleNotice from '@lvbt/ui/astro/lifecycle-notice';
import manifest from '../../lab.config';
---

<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<meta name="robots" content="noindex" />
<title>{manifest.title}</title>
</head>
<body>
<main>
<LabLifecycleNotice manifest={manifest} />
<h1>{manifest.title}</h1>
<p>{manifest.summary}</p>
</main>
</body>
</html>
9 changes: 8 additions & 1 deletion packages/labs-cli/tests/create-archive.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { mkdtemp, rm, writeFile } from 'node:fs/promises';
import { mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
import os from 'node:os';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
Expand Down Expand Up @@ -49,6 +49,13 @@ test.each(['site', 'app'])(
expect(archive).toContain('createArchiveContext');
expect(archive).toContain('archive.failures');
expect(archive).toContain('page.reload()');
if (profile === 'site') {
const template = await readFile(
new URL('../templates/generated-project/site-index.astro', import.meta.url),
'utf8',
);
expect(files?.['src/pages/index.astro']).toBe(template);
}
for (const name of [
'tests/e2e/home.spec.ts-snapshots/page-desktop-lvbt.png',
'tests/e2e/home.spec.ts-snapshots/page-mobile-lvbt.png',
Expand Down
Loading