Repository navigation
Linux: keep the completed ticker step on its own line - #273
Closed
ahmedaly0904-bit64 wants to merge 1 commit into
Closed
ahmedaly0904-bit64 wants to merge 1 commit into
ahmedaly0904-bit64 wants to merge 1 commit into
Conversation
On Linux the overview ticker drew the completed step on top of the current one whenever a step was long enough to overflow the row (a long Bash command, say). Each row stacks a dim copy of its text over the shimmering one; the dim copy is absolutely positioned with no `top`, and WebKitGTK places such a box a full line (16 px) lower once the text before it overflows. Pinning it with `top:0` keeps both copies on the same line. Measured in WebKitGTK 2.52 with the row's DOM and CSS: dim vs shimmer offset was +16 px for overflowing text and -2 px for short text; with `top:0` it is -2 px for both, so short steps look exactly as before. Checked in the running app on Zorin OS 18 (GNOME, X11). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thank you! The same fix ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
top:0, so it always sits on the shimmering layerwindows/src/views/ticker.ts; nothing changes on Windows or for short stepsWhy
On Linux, when a step is long enough to overflow the ticker row (a long Bash command, for instance), the completed step is drawn on top of the current one. Each row stacks a dim copy of its text over the shimmering one; the dim copy is
position:absolutewith notop, so it sits at its static position, and WebKitGTK puts that position a full line (16 px) lower once the text before it overflows. The completed row's visible text then lands on the current row.How to reproduce
npm run tauri build -- --bundles deb --verbose), then any other tool.Exécute · …line overlaps the current step.Validation
top:0it is −2 px in both cases, so short steps render exactly as before.npm run tauri build -- --bundles deb(runstsc --noEmit) — succeeded, no new warnings..deb, ran a long command, and the completed step stays on its own line.🤖 Generated with Claude Code