Repository navigation
Windows i18n strings.json after #330/#331, and steadier open-on-hover tests - #336
Merged
Merged
Conversation
The Spotify strings (#330) and the pill colours (#331) landed on main one after the other, so strings.json no longer matched the Mac's catalog, and "Pause" — now a Mac string — was also in extra.json. npm test is green again (324 pass). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
The cases compared 20-150 ms sleeps with 80-400 ms timers and could race on a loaded macOS runner. The grace period is now 0.3 s, "still open" checks wait 0.6 s against 3 s timers, and waits allow 5 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI on main failed after #330 and #331 landed one after the other:
strings.jsonno longer matched the Mac catalog, and "Pause" (now a Mac string, from Spotify) was also inextra.json.node scripts/gen-strings.mjsnpm test: 324 pass, 0 fail.🤖 Generated with Claude Code
https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
Generated by Claude Code