Skip to content

Windows i18n strings.json after #330/#331, and steadier open-on-hover tests - #336

Merged
Louis-CFM merged 2 commits into
mainfrom
fix/strings-json
Oct 8, 2026
Merged

Louis-CFM merged 2 commits into
mainfrom
fix/strings-json

Conversation

@Louis-CFM

Copy link
Copy Markdown
Owner

Windows CI on main failed after #330 and #331 landed one after the other: strings.json no longer matched the Mac catalog, and "Pause" (now a Mac string, from Spotify) was also in extra.json.

  • node scripts/gen-strings.mjs
  • Removed "Pause" from extra.json (identical translations).
  • npm test: 324 pass, 0 fail.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT


Generated by Claude Code

claude added 2 commits October 8, 2026 13:48
The Spotify strings (#330) and the pill colours (#331) landed on main one
after the other, so strings.json no longer matched the Mac's catalog, and
"Pause" — now a Mac string — was also in extra.json. npm test is green again
(324 pass).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
The cases compared 20-150 ms sleeps with 80-400 ms timers and could race on
a loaded macOS runner. The grace period is now 0.3 s, "still open" checks
wait 0.6 s against 3 s timers, and waits allow 5 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
@Louis-CFM Louis-CFM changed the title Windows i18n: regenerate strings.json after #330/#331 Windows i18n strings.json after #330/#331, and steadier open-on-hover tests Oct 8, 2026
@Louis-CFM
Louis-CFM merged commit a7bd575 into main Oct 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants