Repository navigation
Windows & Linux: the chat's model list had room for less than one model - #363
Closed
shakibbinkabir wants to merge 1 commit into
Closed
shakibbinkabir wants to merge 1 commit into
shakibbinkabir wants to merge 1 commit into
Conversation
The model picker is a popover on macOS, with 260 pt for the list. Here it sits inside the island, in whatever the chat leaves: with an empty conversation the island is 240 px tall and the list had room for one model, scrolled with the arrows of a collapsed scrollbar. While the picker is open the island now takes all the height the panel has (312 px), the way the question view already grows for its options, and comes back to the chat's own height when it closes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Folded into #365, which has this as one of four separate commits you can take or leave on their own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the chat's model picker shows less than one model at a time, and the list can only be moved with the arrows of a collapsed scrollbar. This gives the list room. It is not a redesign: the card, the chips, the rows, the fonts and the colours are untouched. Only the height the island takes while the picker is open changes.
Both are the real app on Windows 11, captured the same way, with the same 14 Anthropic models loaded.
Cause
On macOS the picker is a popover, with
.frame(height: 260)for the list. In the port it sits inside the island, in whatever the chat leaves. With an empty conversation the island is 240 px tall, which leaves the list 23 px for rows that are 28 px tall.Fix
While the picker is open the island takes all the height the panel has (
CHAT_PICKER_H = PANEL_H - 8, so 312 px), the same way the question view already grows for its options (QUESTION_PICKER_H). It returns to the chat's own height when the picker closes. The chat's height callback now picks the shrink curve or the grow spring by direction, since the chat can get shorter as well as taller.What this does not do
It does not reach the Mac's 260 pt. That needs a taller window, and
PANEL_His also the desktop Mochi's home zone and the Linux window geometry, so I left it alone. If you want the full height, I can do that as a follow-up.Tests
npm test: 326 pass, 2 new (the picker tells the island to make room and gives it back; only the chat's height changes).tsc --noEmitclean. No Rust change.🤖 Generated with Claude Code