Repository navigation
Conversation
|
Quick update & note on volume control on Windows While testing and polishing playback controls (shuffle and repeat are working properly over GSMTC), I wanted to share findings regarding the volume slider on Windows: On macOS, Spotify exposes On Windows:
For now, the cleanest path for this PR is to omit the volume bar on Windows rather than shipping an un-synced or misleading slider, and wait to see if Microsoft introduces volume support in a future GSMTC update or if another clean method emerges down the road. Let me know what you think! |
|
@Totopo27, a heads-up so this is not reviewed twice: #374 adds the same thing, a Windows source for the Spotify pill read from the system media session, behind #372's commands and page. It was opened about four hours before this one (8 Oct 23:25 UTC, this one 9 Oct 03:38 UTC) and both are still open. I read your diff against mine. Same API (
The shuffle and repeat row is the one I would like to understand, because we found opposite things. On my machine (Windows 11, Spotify 1.303.264 from the Microsoft Store), |
|
Thanks for the detailed breakdown and heads-up, @shakibbinkabir! Regarding shuffle and repeat: I tested this against the standalone build from spotify.com (\Spotify.exe). While \TryChangeShuffleActiveAsync\ / \TryChangeAutoRepeatModeAsync\ return \ rue\ on the WinRT side and the session triggers a state update, I can confirm the exact same behavior you observed: Spotify's internal player state does not actually toggle. You were totally right to omit those buttons from the card on Windows — having dead buttons that don't alter the actual playback queue is poor UX. Looking at #374, your architecture is much cleaner:
Since #374 was opened earlier and covers the foundation cleanly (along with the opt-in announcement feature), I'm completely fine with closing this PR in favor of #374 so maintainers can focus review efforts there. Happy to test #374 on the standalone installer (\spotify.com) side as well if you need verification outside the Store package! |
Closes #322
Summary
Linux 0.3.0 brought the Spotify pill and Mochi dancing over MPRIS (#372), leaving Windows with "no music source yet". This implements the native Windows source behind the exact same Tauri commands and shared frontend, using WinRT
GlobalSystemMediaTransportControlsSessionManager(GSMTC).Behavior & Parity
IRandomAccessStreamReference) and converts it to a base64 data URI emitted to the existingspotify-artworkevent.spotify:protocol URI.support: "yes"onintegration_spotify, reusing the card, pill hover controls, and Mochi's dance seamlessly on Windows.Tests
npm test: 361 passed (0 failed).cargo test: 213 + 30 passed (0 failed).