Repository navigation
fix: media from the code review (cancels, visualizer, stills, RAW, waveforms, big images), 0.117.7 - #420
Merged
Conversation
…-16 code review) - Conversion cancel during the probe is kept: viewers count from the ask (convertWaiters.ts) - Visualizer drop analysis waits for a known duration, runs once per source, aborts stale runs - Hidden audio tabs run no visualizer draw loop; a click no longer wakes a paused AudioContext - ffmpeg-decoded stills, raw previews and HEIC stream above 8 MB; decoded cache capped by bytes - Raw preview scan uses Buffer.indexOf and caches a copy, not a view of the 40 MB scan buffer - Waveform peaks: one decode at a time, shared per file, cancellable from the renderer - probeCached shares in-flight probes; conversion and peaks go through it - ImageView shows the spinner while a huge picture's bitmap decodes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…el during the stat is kept The peaks job was keyed by the stat-derived cache key, registered only after `await key(file)`. A cancel arriving in that gap found nothing, and the ask then started a whole-file decode for nobody at the head of the one-at-a-time queue, delaying every other waveform. Jobs are now keyed by path and registered synchronously; a cache hit no longer waits in the queue. The renderer sends cancelPeaks only while its ask is still open, so a settled ask cannot take a waiter off another tab's job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media fixes from the 2026-10-16 code review (
research/prism/2026-10-16-code-review.md, findings #5, 6, 12, 13, 16, 20, 23, 24, 25). Built by an Opus agent and reviewed by a second.Fixes
probeCachedshares in-flight probes; conversion and peaks use it.Tests
terminal(one step, passes alone; same in the other branch's run, reported to the PrismTerminal session) andthemeWall(known flaky, passes alone).terminalstep, a core regression from PrismTerminal Test: the busy-file test waits for the lock holder's own word #238 (a Claude that exits within ~3 s keeps its mark); fixed in PrismTerminal Terminal core: prism-term-core core-v0.18.2 (Prism 0.77.1) #243, core 0.41.6.0.117.7.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx