Repository navigation
test(peaks): wait for the spawn, not a fixed tick (flaky on CI) - #421
Merged
Merged
Conversation
…CI cannot fail the waveform jobs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
peaksJobs.test.ts(new in #420) failed on main's ci run after #420 merged, though it passed in the PR check and locally.stat(the cache key) answers.finish(procs[0])finished the wrong job and timed out at 5 s.Fix
Test-only:
spawned(n)waits for the spawn withvi.waitFor(4 s cap) where the tests used to tick and hope. The app code is unchanged.Proof
statmocked to answer after 30 ms: all 4 tests fail before the fix and pass after.🤖 Generated with Claude Code
https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx