Skip to content

test(peaks): wait for the spawn, not a fixed tick (flaky on CI) #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxaubert merged 1 commit into from
Oct 16, 2026
Merged

test(peaks): wait for the spawn, not a fixed tick (flaky on CI) #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/main/peaksJobs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ beforeEach(() => {
})

const tick = (): Promise<void> => new Promise((r) => setTimeout(r, 5))
// A job spawns only after its real stat (the cache key) answers, which can
// take far longer than a tick on a busy CI runner: wait for the spawn itself.
const spawned = (n: number): Promise<void> =>
vi.waitFor(() => expect(procs).toHaveLength(n), { timeout: 4000, interval: 5 })
const finish = (p: Fake): void => {
p.stdout.write(Buffer.from([0, 0x40, 0, 0x20]))
setTimeout(() => p.emit('close', 0), 1)
Expand All @@ -44,22 +48,21 @@ describe('the waveform jobs', () => {
it('runs one decode at a time, and a cancel stops the running one', async () => {
const a = loadPeaks('ffmpeg', 'prism-no-such-dir/a.mkv', 60)
const b = loadPeaks('ffmpeg', 'prism-no-such-dir/b.mkv', 60)
await spawned(1)
await tick()
expect(procs).toHaveLength(1) // b waits its turn
cancelPeaks('prism-no-such-dir/a.mkv')
expect(procs[0].killed).toBe(true)
expect(await a).toBeNull() // a killed job's half-envelope is never kept
await tick()
expect(procs).toHaveLength(2)
await spawned(2)
finish(procs[1])
expect((await b)?.length).toBeGreaterThan(0)
})

it('shares one job between two asks, and keeps it while one still waits', async () => {
const a1 = loadPeaks('ffmpeg', 'prism-no-such-dir/c.mkv', 60)
const a2 = loadPeaks('ffmpeg', 'prism-no-such-dir/c.mkv', 60)
await tick()
expect(procs).toHaveLength(1)
await spawned(1)
cancelPeaks('prism-no-such-dir/c.mkv')
expect(procs[0].killed).toBe(false) // the other tab still wants it
finish(procs[0])
Expand All @@ -75,8 +78,7 @@ describe('the waveform jobs', () => {
expect(procs).toHaveLength(0)
// ...and nothing was left at the head of the queue: the next file decodes.
const next = loadPeaks('ffmpeg', 'prism-no-such-dir/g.mkv', 60)
await tick()
expect(procs).toHaveLength(1)
await spawned(1)
finish(procs[0])
expect((await next)?.length).toBeGreaterThan(0)
})
Expand All @@ -85,7 +87,7 @@ describe('the waveform jobs', () => {
const first = loadPeaks('ffmpeg', 'prism-no-such-dir/d.mkv', 60)
const probe = vi.fn(async () => 60)
const queued = loadPeaks('ffmpeg', 'prism-no-such-dir/e.mkv', probe)
await tick()
await spawned(1)
cancelPeaks('prism-no-such-dir/e.mkv')
finish(procs[0])
await first
Expand Down
Loading