Repository navigation
perf(db): resolve packet endpoints at read time - #163
Merged
Merged
Conversation
Storing a full candidate snapshot on every observation was the wrong call. The same node lists got copied thousands of times, about 22 GB on prod. Resolve endpoints live like path hops and drop the column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#128 saved a full snapshot of every endpoint candidate (id, name, key, location) on each observation. In hindsight that was the wrong choice. Ambiguous one-byte hashes match ~7 nodes on average, and the same list got copied for every observer and every packet. On prod it grew to about 22 GB, roughly 60% of packet_observations.
This drops the column and resolves source/destination at read time, same as path hops already do.
Tradeoff: old packets show today's node names rather than the ones at capture time. With 3 to 7 day retention that barely matters.
Migration 038 drops
resolved_endpoints. Space comes back as old rows age out, or right away withVACUUM FULL packet_observations.