Skip to content

fix: follow up on the #75-#99 stack review - #101

Merged
MrAlders0n merged 1 commit into
devfrom
fix/stack-review-followups
Sep 30, 2026
Merged

MrAlders0n merged 1 commit into
devfrom
fix/stack-review-followups

Conversation

@MrAlders0n

Copy link
Copy Markdown
Member

Follow-up to the #99 squash. Fixes the review items that were still open when the stack landed, and folds in #93.

Blockers

  • fix(history): align chart periods with retained packet data #95 capped observer, route and compare windows at 3 days, which was one deployment's retention. The server keeps 7 days by default and serves up to 720h. This puts back 24h/7d/30d everywhere (Analytics, the Observer page, route evidence, compare). Retired range=3d links fall back to the default.
  • fix(ui): prepare compact observer monitoring for 1.3.2 #99 hid the All observers button on desktop, which left no way back to the directory. The button is back, and the compact sidebar now ignores the status/type/broker/scope filters it has no controls for.

View on map (from #93, credit @vfortin99-ctrl)

  • Node panels with a location get a View on map link. It opens the Map tab framed on the node at zoom 14 and keeps the panel open on desktop.
  • It isn't offered on the Map tab itself, because the map only reads lat/lng on mount.
  • lat/lng/zoom are cleared when leaving the Map tab, so later visits frame the region again.
  • It goes through the normal tab change, so stacked investigation panels close and the node is selected on the map.

Cleanup

  • The native candidates tooltip now appears only on packet endpoint chips. Path hops in the drawer use the popover alone.
  • Removed 12 unused translation keys, a stale StatsOverview comment and the dead observer stats tab.
  • Stubbed localStorage in the quick-observer App test and moved stray top-level tests into their describe blocks.

Build passes and lint has 0 errors. Tests: 957/969. The 12 failures are the i18n/LanguagePicker/AppShell tests that already fail on dev under Node 26 (localStorage).

Not changed: the 1.3.2 version bump and Observers being the first tab, both from #99.

- Restore 24h/7d/30d windows for observers, routes, compare and analytics;
  the 3-day cap matched one deployment, not the server's 7-day default
- Keep the All observers button on desktop and ignore directory filters the
  compact sidebar can't show
- Add View on map to node panels (from #93): not offered on the Map tab,
  map params cleared when leaving it, stacked panels closed on the way
- Limit the native candidates tooltip to packet endpoint chips
- Drop unused translation keys, stale comments and the dead observer stats tab
- Stub localStorage in the quick-observer App test; tidy stray test blocks

Co-authored-by: ItsMeVino <249552181+vfortin99-ctrl@users.noreply.github.com>
@MrAlders0n
MrAlders0n merged commit 39b85a9 into dev Sep 30, 2026
2 checks passed
@MrAlders0n
MrAlders0n deleted the fix/stack-review-followups branch September 30, 2026 12:35
MrAlders0n added a commit that referenced this pull request Sep 30, 2026
Bugs: clear compare params on tab change, recover channel live messages after a 429,
observer copy link keeps only region params, route table no longer navigates on region
change with nothing selected, map borders memo on data identity, live overview can't
resurrect a failed query, French relative times, no language write on first visit,
0/0 node locations hidden outside the map, path/signal stats use the shared retry rule.

i18n: node/packet/mesh/observer strings that were still hardcoded after #62.

Cleanup: formatUtc, ACTION_BUTTON_CLASS, observer-stats, useWindowedStats, observer-id;
observer pages use StatCard/Card/Field/Segmented/SearchBar/SelectDropdown; one details
chrome on the stats tabs; comment and translations-guide trims; localStorage stub for
Node 26 in the test setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant