fix: follow up on the #75-#99 stack review - #101
Merged
Merged
Conversation
- Restore 24h/7d/30d windows for observers, routes, compare and analytics; the 3-day cap matched one deployment, not the server's 7-day default - Keep the All observers button on desktop and ignore directory filters the compact sidebar can't show - Add View on map to node panels (from #93): not offered on the Map tab, map params cleared when leaving it, stacked panels closed on the way - Limit the native candidates tooltip to packet endpoint chips - Drop unused translation keys, stale comments and the dead observer stats tab - Stub localStorage in the quick-observer App test; tidy stray test blocks Co-authored-by: ItsMeVino <249552181+vfortin99-ctrl@users.noreply.github.com>
4 tasks done
MrAlders0n
added a commit
that referenced
this pull request
Sep 30, 2026
Bugs: clear compare params on tab change, recover channel live messages after a 429, observer copy link keeps only region params, route table no longer navigates on region change with nothing selected, map borders memo on data identity, live overview can't resurrect a failed query, French relative times, no language write on first visit, 0/0 node locations hidden outside the map, path/signal stats use the shared retry rule. i18n: node/packet/mesh/observer strings that were still hardcoded after #62. Cleanup: formatUtc, ACTION_BUTTON_CLASS, observer-stats, useWindowedStats, observer-id; observer pages use StatCard/Card/Field/Segmented/SearchBar/SelectDropdown; one details chrome on the stats tabs; comment and translations-guide trims; localStorage stub for Node 26 in the test setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #99 squash. Fixes the review items that were still open when the stack landed, and folds in #93.
Blockers
range=3dlinks fall back to the default.View on map (from #93, credit @vfortin99-ctrl)
Cleanup
observerstats tab.Build passes and lint has 0 errors. Tests: 957/969. The 12 failures are the i18n/LanguagePicker/AppShell tests that already fail on dev under Node 26 (localStorage).
Not changed: the 1.3.2 version bump and Observers being the first tab, both from #99.