Skip to content

feat(routes): inspect retained packets and reporting observers - #85

Closed
n30nex wants to merge 20 commits into
MeshCore-Beacon:devfrom
n30nex:codex/beacon-route-evidence-view
Closed

n30nex wants to merge 20 commits into
MeshCore-Beacon:devfrom
n30nex:codex/beacon-route-evidence-view

Conversation

@n30nex

@n30nex n30nex commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Saved routes show exact retained report evidence, named hops and observer/packet actions. Named-region resolution no longer clears a shared route selection. Route parameters are cleared when leaving the page, inspection uses consistent history replacement, unknown hash widths stay unknown, and future fixed windows have an explicit invalid-window response.

Closes #84. Parent 327ea06e92a1fbbdc2674d14ec8386216ce63a2a, head 7a82605e8ecbf343bc5f0d9d4b800a43d7243ab5. Focused diff.

Windows build/lint/full tests and published-head checks pass (upstream web CodeQL is skipped). The combined native Pi web build/lint passes all 955 tests at eb241ca7, paired with server 397d76b3. Desktop/phone, English/French, keyboard, navigation and public source/asset checks pass. Release scope and recovery / running preview. Atlas is excluded from this release cut.

Maintainers retain acceptance, merges, tags and production release.

@n30nex

n30nex commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

@MrAlders0n, ready for your / Claude's review at 3b3abdcc. This is the focused route -> retained report/packet/observer slice; it follows #83 and requires server #172 deployed first. Final Pi build/lint and all 915 tests pass, as does exact-head CI. Desktop/phone, English/French, Back/shared links and selected-report/map/keyboard Close journeys are checked.

Try the deployed route page. Source/changelog matches the exact tested build and includes every prior review candidate. The phone width issue found in QA is fixed. Existing observer Escape and broader return navigation are tracked separately in #86, the next roadmap issue. Closes #84 on acceptance.

@n30nex
n30nex force-pushed the codex/beacon-route-evidence-view branch from 3b3abdc to b21b870 Compare September 28, 2026 22:38
@MrAlders0n

Copy link
Copy Markdown
Member

Types line up with server #172. One bug:

  • RouteTable.tsx:314-323: the region-change effect now calls closeRoute(), which strips the route* params. With a named region (?regions=<slug>, or one restored from storage), regionKey is "*" until the regions query resolves and then changes. So a shared route link, or a reload on Routes, opens the panel and wipes it straight away. Please key it on the selection (the way SelectionResetOnRegion does) and add a test.

Minor:

  • handleTabChange leaves the route* params behind on other tabs.
  • Open pushes a history entry but Close replaces it, so the first Back does nothing.
  • RouteEvidencePanel.tsx:265: hashSize is 0 (not null) when matchAvailable is false, so it shows "0 byte(s) per hop".
  • A future until gets the generic error instead of the invalid-window message.

@n30nex
n30nex force-pushed the codex/beacon-route-evidence-view branch from b21b870 to 7a82605 Compare September 30, 2026 10:47
@n30nex

n30nex commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

@MrAlders0n / Claude: September 30 follow-up at 7a82605e.

Region changes now follow the stable selection rather than asynchronous region-key resolution. Fixed shared links survive loading; route navigation/history, unknown widths and future-window feedback are corrected and tested.

Windows build/lint/full tests and published-head checks pass (upstream web CodeQL is skipped). The combined native Pi web build/lint passes all 955 tests at eb241ca7, paired with server 397d76b3. Desktop/phone, English/French, keyboard, navigation and public source/asset checks pass. Release scope and recovery / running preview. Atlas is excluded from this release cut.

Please re-review the current head when convenient. No upstream merge or tag was performed.

MrAlders0n pushed a commit that referenced this pull request Sep 30, 2026
)

Lands the stacked web PRs #75, #79, #80, #81, #83, #85, #87, #89, #92, #95 and #99 in one squash. Server counterparts #166-#176 are merged. Remaining review items follow in a fix PR.
@MrAlders0n

Copy link
Copy Markdown
Member

Landed as part of #99 (squash d259be5). Remaining review items will be handled in a follow-up fix PR.

@MrAlders0n MrAlders0n closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connect saved routes to retained packets and reporting observers

2 participants