Repository navigation
Classify Grok not-signed-in as provider authentication failure - #744
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a managed Grok account's credentials are missing or expired, the Grok CLI emits
Not signed in. To authenticate without a browser, run: ....is_inference_authentication_errormatched onlynot authenticated, so this failure surfaced as a generic exit 1 with emptyenvironment_failures.Only the auditors later recovered
provider_auth_required.This change recognizes
not signed in(case-insensitive) inside the existing error-event-only classifier.It adds the captured CLI event as a fixture and asserts propagation through
retain_grok_stream_auth_failure.Negative cases for ordinary text and catalog banners are unchanged.
Validation
cargo fmt --check, clippy, and these exact tests:runtime_adapter::grok::tests::inference_auth_failures_are_observed_only_in_worker_errors_and_redacted_native_failuresexternal_agent::tests::grok_native_auth_failure_is_environment_and_fails_closed