Skip to content

Fix Jellyseerr advanced request popup and cancel dialog layout#216

Open
IAvecilla wants to merge 2 commits into
Moonfin-Client:mainfrom
IAvecilla:fix/request-quality-profiles-webos
Open

Fix Jellyseerr advanced request popup and cancel dialog layout#216
IAvecilla wants to merge 2 commits into
Moonfin-Client:mainfrom
IAvecilla:fix/request-quality-profiles-webos

Conversation

@IAvecilla
Copy link
Copy Markdown

Pull Request

Summary

Two small fixes in the Jellyseerr details view. The "Continue with Options" path in the Request Options popup was unreachable when the user's only Radarr/Sonarr server in Seerr had id: 0, the load effect bailed out on a falsy-zero check, so the server details fetch never ran, no profiles/root folders were available, and "Continue with Options" was silently equivalent to "Use Defaults". Also the Cancel Request popup auto-focused the destructive action and overflowed its container when re-ordered, so Keep Request now gets initial focus and the popup grows to fit both buttons.

Related Issues

N/A: surfaced while testing the Jellyseerr request flow against a real Radarr server whose Seerr-side id was 0.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • JellyseerrDetails.js: replace if (!selectedServerId || !open) return; with if (selectedServerId == null || !open) return; in AdvancedOptionsPopup's server-details load effect. !0 was treating a legitimate server id as "nothing selected", so GET /service/radarr/0 never fired.
  • JellyseerrDetails.js (CancelRequestPopup): swap button order so "Keep Request" renders first, add spotlightId and an useEffect that calls safeFocus('cancel-request-keep') via requestAnimationFrame when the popup opens, matching the focus pattern used in this file.
  • JellyseerrDetails.module.less: drop max-width: 400px from .cancelPopupContent so the popup grows to fit two Sandstone <Button>s side-by-side.

Platform

  • Tizen (Samsung)
  • webOS (LG)
  • Both / Shared code

Testing

  • Tested on emulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Verified on an LG webOS TV against a live Jellyseerr instance with just one Radarr server.

Test Steps

  1. Open the Moonfin Jellyseerr Details view for any movie that's requestable, with a Seerr account that has the "Request Advanced" permission and a single Radarr server configured (id 0 to actually see the failing case working now).
  2. Press the Request button. When the Request Options popup appears, confirm the Quality Profile and Download Location sections populate and "Continue with Options" is enabled. Submitting it produces a request with the chosen profile/root folder in Seerr → Requests.
  3. With a request already pending, press the Cancel Request action on the same details screen. Confirm the popup grows to fit both buttons side-by-side.

Screenshots

Before:empty "Request Options" popup, "Continue with Options" disabled even though the user had advanced permissions:

Request Options

After: Request Options populated with Quality Profile + Download Location pickers.

Request Options

Before: Cancel Request popup with destructive action auto-focused and the second button overflowing the popup card:

s later to

After: Keep Request focused on the left, Cancel Request on the right, both inside the popup card.
Cancel Request

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant