Fix Jellyseerr advanced request popup and cancel dialog layout#216
Open
IAvecilla wants to merge 2 commits into
Open
Fix Jellyseerr advanced request popup and cancel dialog layout#216IAvecilla wants to merge 2 commits into
IAvecilla wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Two small fixes in the Jellyseerr details view. The "Continue with Options" path in the Request Options popup was unreachable when the user's only Radarr/Sonarr server in Seerr had
id: 0, the load effect bailed out on a falsy-zero check, so the server details fetch never ran, no profiles/root folders were available, and "Continue with Options" was silently equivalent to "Use Defaults". Also the Cancel Request popup auto-focused the destructive action and overflowed its container when re-ordered, so Keep Request now gets initial focus and the popup grows to fit both buttons.Related Issues
N/A: surfaced while testing the Jellyseerr request flow against a real Radarr server whose Seerr-side id was 0.
Type of Change
Changes Made
JellyseerrDetails.js: replaceif (!selectedServerId || !open) return;withif (selectedServerId == null || !open) return;inAdvancedOptionsPopup's server-details load effect.!0was treating a legitimate server id as "nothing selected", soGET /service/radarr/0never fired.JellyseerrDetails.js(CancelRequestPopup): swap button order so "Keep Request" renders first, addspotlightIdand anuseEffectthat callssafeFocus('cancel-request-keep')viarequestAnimationFramewhen the popup opens, matching the focus pattern used in this file.JellyseerrDetails.module.less: dropmax-width: 400pxfrom.cancelPopupContentso the popup grows to fit two Sandstone<Button>s side-by-side.Platform
Testing
Verified on an LG webOS TV against a live Jellyseerr instance with just one Radarr server.
Test Steps
Screenshots
Before:empty "Request Options" popup, "Continue with Options" disabled even though the user had advanced permissions:
After: Request Options populated with Quality Profile + Download Location pickers.
Before: Cancel Request popup with destructive action auto-focused and the second button overflowing the popup card:
After: Keep Request focused on the left, Cancel Request on the right, both inside the popup card.

Checklist