Skip to content

Fix Jellyseerr advanced request popup and cancel dialog layout #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IAvecilla wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −4
Open

Fix Jellyseerr advanced request popup and cancel dialog layout #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb39e99
Check for null instead of 0 to avoid false positives with first index
IAvecilla May 23, 2026
eff942a
Fix layout for request cancel pop up
IAvecilla May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/app/src/views/JellyseerrDetails/JellyseerrDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ const AdvancedOptionsPopup = memo(({open, title, servers, is4k, onConfirm, onClo
}, [open, availableServers]);

useEffect(() => {
if (!selectedServerId || !open) return;
if (selectedServerId == null || !open) return;

const loadServerDetails = async () => {
setLoadingDetails(true);
Expand Down Expand Up @@ -655,18 +655,29 @@ const CancelRequestPopup = memo(({open, pendingRequests, title, onConfirm, onClo
return $L('Cancel {parts} requests for "{title}"?').replace('{parts}', partsStr).replace('{title}', title);
}, [pendingRequests, title]);

useEffect(() => {
if (!open) return;
window.requestAnimationFrame(() => {
safeFocus('cancel-request-keep');
});
}, [open]);

return (
<Popup open={open} onClose={onClose} position="center" className={css.cancelPopup}>
<div className={css.cancelPopupContent}>
<h2 className={css.cancelPopupTitle}>{$L('Cancel Request')}</h2>
<p className={css.cancelPopupDescription}>{description}</p>
<div className={css.cancelButtons}>
<Button
className={css.cancelKeepButton}
spotlightId="cancel-request-keep"
onClick={onClose}
>
{$L('Keep Request')}
</Button>
<Button className={css.cancelConfirmButton} onClick={onConfirm}>
{$L('Cancel Request')}
</Button>
<Button className={css.cancelKeepButton} onClick={onClose}>
{$L('Keep Request')}
</Button>
</div>
</div>
</Popup>
Expand Down
Loading