Skip to content

Fix services#215

Merged
SantiagoPidji merged 47 commits into
mainfrom
fix-services
Nov 2, 2025
Merged

Fix services#215
SantiagoPidji merged 47 commits into
mainfrom
fix-services

Conversation

@Arkteus

@Arkteus Arkteus commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces several documentation and backend improvements, focusing on enhanced service documentation, clarifying core models and relationships, and refining email sending functionality. It also removes the deprecated webhook service and updates tests accordingly.

Documentation Enhancements:

  • Added a comprehensive section in README.md listing all available services, their features, OAuth requirements, and key API endpoints, including example automation flows.
  • Expanded HOWTOCONTRIBUTE.md with a Mermaid class diagram to visualize core model relationships, and included detailed implementation examples for different types of services (simple, OAuth, webhook-based, etc.). [1] [2]

Backend Functionality Improvements:

  • Implemented real email sending for the send_email reaction using Django's email backend (e.g., SendGrid), replacing the previous placeholder logic.
  • Extended the send_email reaction's configuration schema to require recipient, subject, and body fields, improving validation and usability.

Service and Test Maintenance:

  • Removed the deprecated webhook service and its associated actions/reactions from service initialization and updated all related tests to reflect this removal. [1] [2] [3] [4]
  • Removed an obsolete test for storing complex JSON in execution model fields.

Test Corrections:

  • Fixed timer action tests to mock the correct Celery task (execute_reaction_task instead of execute_reaction). [1] [2] [3]

maelemiel and others added 30 commits November 2, 2025 03:12
@Arkteus Arkteus requested a review from Copilot November 2, 2025 18:23
@Arkteus Arkteus self-assigned this Nov 2, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes the "webhook" service from the AREA platform and improves the frontend's service connection logic to properly handle OAuth providers and multi-service Google authentication. Key changes include:

  • Removal of webhook as an internal service (replaced by email service in tests and configurations)
  • Enhanced OAuth provider mapping for Google services (Gmail, Calendar, YouTube)
  • Improved documentation with detailed service examples and deployment configurations
  • Added comprehensive test runner script with coverage reporting
  • Updated environment templates with better structure and security guidance

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
frontend/src/pages/Services.tsx Removed 'webhook' from internal services list
frontend/src/pages/Dashboard.tsx Enhanced OAuth provider mapping logic; removed webhook; added Google multi-service support
frontend/src/components/NotionWebhookSection.tsx Updated UI styling for webhook configuration section
docker-compose.override.yml Changed environment variable name for frontend port consistency
backend/scripts/run_tests.sh Added comprehensive test runner with coverage reporting
backend/pyproject.toml Fixed coverage source configuration format
backend/automations/tests/*.py Replaced webhook service with email service in test fixtures
backend/automations/tasks.py Implemented real email sending via SendGrid
backend/automations/management/commands/init_services.py Removed webhook service definition; added email config schema
README.md Added services table and comprehensive API documentation
HOWTOCONTRIBUTE.md Added class diagrams and detailed service implementation examples
.gitignore Added htmlcov directory exclusion
.env.production Restructured with enhanced documentation and security guidance
.env.example Restructured with enhanced documentation and clearer setup instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/pages/Dashboard.tsx
Comment thread frontend/src/pages/Dashboard.tsx
Comment thread backend/pyproject.toml
@Arkteus Arkteus marked this pull request as ready for review November 2, 2025 18:46
@SantiagoPidji SantiagoPidji self-requested a review November 2, 2025 18:47

@SantiagoPidji SantiagoPidji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SantiagoPidji SantiagoPidji merged commit 6c68220 into main Nov 2, 2025
6 checks passed
@SantiagoPidji SantiagoPidji deleted the fix-services branch November 2, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants