Repository navigation
SetWorld behavior - #53
Closed
msavchen-nasa wants to merge 3 commits into
Closed
msavchen-nasa wants to merge 3 commits into
msavchen-nasa wants to merge 3 commits into
Conversation
msavchen-nasa
requested review from
eholum-nasa,
ndunkelb-nasa and
scastro-nasa
September 30, 2026 21:32
scastro-nasa
reviewed
Oct 1, 2026
Contributor
There was a problem hiding this comment.
A few alternative options for dependencies:
- Make a new file (e.g.,
phoebe_behaviors) so that way we can select to import it in the behavior config YAMLs. Same deal as e.g. what we do with the color behaviors that exist in this repo, so you can follow that pattern. - Move the
SetWorldmessage definition to theimetro_behavior_msgspackage in this repo? - Move this entire new behavior to the DSpARC workspaces themselves -- no reason why we can't have specialized behaviors in other repos, in the same way we have RoboPlan behaviors directly in the
clr_ws.
I'm honestly fine with any of the above as preferable alternatives to the try/catch method that's currently there.
Contributor
Author
And here I thought I was being creative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let me know what you think