Skip to content

SetWorld behavior - #53

Closed
msavchen-nasa wants to merge 3 commits into
mainfrom
msavchen/set-world-behavior
Closed

msavchen-nasa wants to merge 3 commits into
mainfrom
msavchen/set-world-behavior

Conversation

@msavchen-nasa

Copy link
Copy Markdown
Contributor
  • Behavior for using SetWorld transform
  • my take on how to deal with dependencies
    let me know what you think

@scastro-nasa scastro-nasa left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few alternative options for dependencies:

  1. Make a new file (e.g., phoebe_behaviors) so that way we can select to import it in the behavior config YAMLs. Same deal as e.g. what we do with the color behaviors that exist in this repo, so you can follow that pattern.
  2. Move the SetWorld message definition to the imetro_behavior_msgs package in this repo?
  3. Move this entire new behavior to the DSpARC workspaces themselves -- no reason why we can't have specialized behaviors in other repos, in the same way we have RoboPlan behaviors directly in the clr_ws.

I'm honestly fine with any of the above as preferable alternatives to the try/catch method that's currently there.

@msavchen-nasa

Copy link
Copy Markdown
Contributor Author

A few alternative options for dependencies:

  1. Make a new file (e.g., phoebe_behaviors) so that way we can select to import it in the behavior config YAMLs. Same deal as e.g. what we do with the color behaviors that exist in this repo, so you can follow that pattern.
  2. Move the SetWorld message definition to the imetro_behavior_msgs package in this repo?
  3. Move this entire new behavior to the DSpARC workspaces themselves -- no reason why we can't have specialized behaviors in other repos, in the same way we have RoboPlan behaviors directly in the clr_ws.

I'm honestly fine with any of the above as preferable alternatives to the try/catch method that's currently there.

And here I thought I was being creative.
I like option 3 the best, but I would like @ndunkelb-nasa and @eholum-nasa to chime in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants