Skip to content

Behavior for inverting transform stamped message - #55

Merged
msavchen-nasa merged 7 commits into
mainfrom
msavchen/transform-inverse
Oct 14, 2026
Merged

msavchen-nasa merged 7 commits into
mainfrom
msavchen/transform-inverse

Conversation

@msavchen-nasa

Copy link
Copy Markdown
Contributor

No description provided.

@msavchen-nasa msavchen-nasa self-assigned this Oct 6, 2026

@scastro-nasa scastro-nasa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed because the "forward" transform was already looked up and being used by a previous behavior? Because otherwise I might recommend just calling the "lookup transform" behavior but with the arguments reversed?

Comment thread src/imetro_behavior/imetro_behavior/geometry_behaviors.py Outdated
Comment thread src/imetro_behavior/imetro_behavior/geometry_behaviors.py Outdated

@ndunkelb-nasa ndunkelb-nasa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine after the minor comments! Would be good to add in a test for some simple inversion cases too!

Comment thread src/imetro_behavior/imetro_behavior/geometry_behaviors.py Outdated
@msavchen-nasa

Copy link
Copy Markdown
Contributor Author

is this needed because the "forward" transform was already looked up and being used by a previous behavior? Because otherwise I might recommend just calling the "lookup transform" behavior but with the arguments reversed?

I tried doing that,
the problem with that is that in order to get b_T_a we have to publish a_T_b to the tf buffer first.
With static transforms publications the buffer can keep both of these transforms and create something like this on the tf graph

graph LR
    A((a)) --> B((b))
    B --> A 
Loading

this behavior should let you avoid that.

@msavchen-nasa
msavchen-nasa marked this pull request as ready for review October 14, 2026 13:57
Comment thread src/imetro_behavior/tests/test_geometry_behaviors.py
@msavchen-nasa
msavchen-nasa merged commit 6f899e5 into main Oct 14, 2026
4 checks passed
@msavchen-nasa
msavchen-nasa deleted the msavchen/transform-inverse branch October 14, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants