Skip to content

FPM-586 - Remove base flag column#69

Merged
richjam merged 3 commits intomainfrom
feature/FPM-586-remove-base-flag-column
Mar 26, 2026
Merged

FPM-586 - Remove base flag column#69
richjam merged 3 commits intomainfrom
feature/FPM-586-remove-base-flag-column

Conversation

@richjam
Copy link
Copy Markdown
Collaborator

@richjam richjam commented Mar 25, 2026

Background

Flag columns previously required a base data column to be specified on creation. This was used in two places: generating a default column name, and auto-including flag columns in select. Neither use case justified the constraint - flags may apply to multiple columns, or to none in particular. This PR removes base entirely from the flag column.

Main changes

  • base removed from the flag manager class, and all associated methods
  • default column name (in init_flag_column) changed to omit the base column - and added the 'collision avoidance' in case column name already exists
  • Removed include_flag_columns from the select method

Note

  • Documentation will be modified in another PR

@richjam richjam merged commit ba8a74d into main Mar 26, 2026
3 checks passed
@richjam richjam deleted the feature/FPM-586-remove-base-flag-column branch March 26, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants