feat(player): share one lyrics panel across player layouts - #71
Closed
mihaimetal wants to merge 1 commit into
Closed
mihaimetal wants to merge 1 commit into
mihaimetal wants to merge 1 commit into
Conversation
Extract PlayerMediaPanel so the side player and the bottom-bar popover render the same lyrics surface, including the source picker header on the popover.
4 tasks
Contributor
Author
|
Closing in favor of #72 — this was only the |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlayerMediaPanelso the side player and the bottom-bar lyrics popover render the same lyrics surface.Why
Both layouts were independently wiring
LyricsBody+ a one-off header. A shared panel keeps them in sync and is the hook the chapters PR hangs tabs on.Scope
Frontend-only, rebased cleanly on
v0.4.4/ currentorigin/main. No playback, auth, or stream-resolve commits.Test plan
pnpm testtsc --noEmitNotes
Independent of the macOS / WEB_REMIX / speed PRs. The follow-up chapters PR (
feature/chapters) stacks on this commit.