Skip to content

feat(player): share one lyrics panel across player layouts - #71

Closed
mihaimetal wants to merge 1 commit into
NUber-dev:mainfrom
mihaimetal:feature/lyrics
Closed

mihaimetal wants to merge 1 commit into
NUber-dev:mainfrom
mihaimetal:feature/lyrics

Conversation

@mihaimetal

Copy link
Copy Markdown
Contributor

Summary

  • Extract PlayerMediaPanel so the side player and the bottom-bar lyrics popover render the same lyrics surface.
  • The popover keeps its source-picker header; the side player stays headerless until a later chapters change needs tabs.

Why

Both layouts were independently wiring LyricsBody + a one-off header. A shared panel keeps them in sync and is the hook the chapters PR hangs tabs on.

Scope

Frontend-only, rebased cleanly on v0.4.4 / current origin/main. No playback, auth, or stream-resolve commits.

Test plan

  • pnpm test
  • tsc --noEmit
  • Side player: lyrics still flow under the cover, source picker still in the bottom row
  • Bottom-bar lyrics popover: title + source picker + lyrics body
  • No track: lyrics button stays disabled

Notes

Independent of the macOS / WEB_REMIX / speed PRs. The follow-up chapters PR (feature/chapters) stacks on this commit.

Extract PlayerMediaPanel so the side player and the bottom-bar
popover render the same lyrics surface, including the source picker
header on the popover.
@mihaimetal

Copy link
Copy Markdown
Contributor Author

Closing in favor of #72 — this was only the PlayerMediaPanel extract that chapters hangs tabs on. Combined into one PR so there isn't a one-commit stack to review separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant