Repository navigation
[merge-to-it] cloudxr: route OOB progress and headset events through logging - #1201
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughOOB teleoperation progress messages now use INFO logging when logging is enabled and cyan stderr output otherwise. Lifecycle publications report initial connection, resumed streaming, and disconnection events. Shutdown closes stale teleoperation tabs before cleaning up owned ADB rules. The asleep-headset warning now describes automatic wake and connection when OOB automation is enabled. Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Publication
participant _publish
participant oob_progress
participant Output
Publication->>_publish: health and streaming flags
_publish->>oob_progress: connection, resumption, or disconnection event
oob_progress->>Output: INFO log or stderr progress line
Merge Risk: ⚪ Minimal · up to The supplied evidence identifies no issue that needs resolution before merging after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
5d4afa8 to
f9938ee
Compare
632a6df to
f9938ee
Compare
6f72db8 to
ecff0dd
Compare
…logging Signed-off-by: Lotus Li <lotusl@nvidia.com>
assert_headset_awake() now gates CONNECT, the USB-local transfer and webclient.py with require_awake=True, so a headset that stays asleep blocks OOB until it is worn or unlocked. "It will automatically wake up and connect" no longer holds, and the helper is also reached outside OOB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lotus Li <lotusl@nvidia.com>
… waits for wake Same-tab CONNECT runs only after the stream ended, and its other publishes already carry streaming=False. The WAITING_FOR_AWAKE publish added with the wake gate did not, so a stream that ended because the headset went to sleep was announced only once it woke. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lotus Li <lotusl@nvidia.com>
ecff0dd to
bcc6148
Compare
[merge-to-it]
Summary
Brings the CloudXR OOB flow into the logging system:
oob_progress()logs[<stage>] <msg>at INFO onisaaccapture.cloudxr.oob_teleop_env(still printed to stderr whenISAACCAPTURE_LOGGING=off), and that logger is cyan by default in_logger_colors.OobLifecycle._publish()reports headset connect, disconnect and reconnect throughoob_progress(). A disconnect is announced only when the stream itself is lost, not when metrics merely go stale.Testing
tests/python/core/cloudxr:test_oob_teleop_env.py,test_oob_teleop_adb.py(126 passed),test_oob_teleop_lifecycle.py;tests/python/core/logging_config/test_console.py; pre-commit.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes