Skip to content

Disconnect when the oob program quits. - #1231

Merged
lotusl-code merged 1 commit into
mainfrom
lotusl/disconnect-when-oob-program-quits
Oct 9, 2026
Merged

lotusl-code merged 1 commit into
mainfrom
lotusl/disconnect-when-oob-program-quits

Conversation

@lotusl-code

@lotusl-code lotusl-code commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Split from #1201. When the oob host program is terminated, exit connection on the headset.

Summary by CodeRabbit

  • Bug Fixes
    • Stale teleoperation tabs are now closed on the selected headset during shutdown. If closing a tab fails, shutdown continues.

@lotusl-code
lotusl-code requested a review from sgrizan-nv October 9, 2026 18:48
@lotusl-code lotusl-code self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 81280617-beb9-4920-a63d-d379877160fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 387a638e-97e9-4e51-9e5c-d5f25571bbd7

📥 Commits

Reviewing files that changed from the base of the PR and between 3641911 and 2b3ec0e.


📒 Files selected for processing (2)
  • src/python/isaaccapture/cloudxr/oob_teleop_lifecycle.py
  • tests/python/core/cloudxr/test_oob_teleop_lifecycle.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.



📝 Walkthrough

Walkthrough

OobLifecycle now closes stale teleop tabs during shutdown. It performs this step after stopping the monitor and before cleaning up owned ADB mappings. If tab closure fails, the lifecycle logs the failure and continues shutdown. The cable-flap recovery test now expects one stale-tab close during shutdown.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes


Merge Risk: ⚪ Minimal · up to 2b3ec

On the supported stop path, stale teleop tabs are closed before owned ADB mappings are cleaned up, and the inspected cancellation flow does not interrupt that sequence. No actionable merge risk remains.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: disconnect the headset when the OOB program exits.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Lotus Li <lotusl@nvidia.com>
@lotusl-code
lotusl-code force-pushed the lotusl/disconnect-when-oob-program-quits branch from 2b3ec0e to edfd695 Compare October 9, 2026 23:01
@lotusl-code
lotusl-code enabled auto-merge (squash) October 9, 2026 23:03
@lotusl-code
lotusl-code merged commit 2442189 into main Oct 9, 2026
33 checks passed
@lotusl-code
lotusl-code deleted the lotusl/disconnect-when-oob-program-quits branch October 9, 2026 23:19

This branch was successfully deployed

1 active deployment
dev — edfd6957 Deployed Oct 9, 2026 by lotusl-code via publish-wheel #5495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants