Repository navigation
fix(webxr): let 0 disable the stream-attach and warm-up timeouts - #1257
Merged
gareth-morgan-nv merged 1 commit intoOct 13, 2026
Merged
Conversation
streamAttachTimeoutMs, warmupBeginTimeoutMs and warmupEndTimeoutMs were passed straight to setTimeout, so 0 fired the timer immediately instead of turning detection off. Treat a value <= 0 as disabled for each timer. warmupEndTimeoutMs <= 0 also disables the warm-up-begin timer, since that timer only hands off to the end timer; stream-attach detection is unaffected. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Contributor
gareth-morgan-nv
requested review from
AndreusNvidius,
sgrizan-nv and
tengw-nv
October 13, 2026 18:52
2 of 3 tasks
sgrizan-nv
approved these changes
Oct 13, 2026
gareth-morgan-nv
deleted the
gmorgan/webxr-zero-disables-startup-timeouts
branch
October 13, 2026 19:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streamAttachTimeoutMs,warmupBeginTimeoutMsandwarmupEndTimeoutMswere passed straight tosetTimeout, so a value of0fired the timer immediately instead of turning detection off. There was no supported way to disable the detection short of a ~24-day timeout.<= 0now disables each of the three timers (armStreamAttachTimer,armWarmupBeginTimer,armWarmupEndTimerreturn early). All arming sites go through these, including the config re-arm effect and theonLogbegin-to-end handoff.warmupEndTimeoutMs <= 0also disables the warm-up-begin timer: that timer only hands off to the end timer, so leaving it armed would still tear the session down. Stream-attach detection is unaffected.Use case: setups where the OpenXR app starts after the client connects. The runtime sends small empty keep-alive frames until an app submits frames, which the client counts as decoder warm-up, so the 30s end timer can fire before the app is up and force a reconnect.
?warmupEndTimeoutMs=0turns warm-up detection off for that flow.Test plan
jest src/config, eslint and prettier clean on the touched files;tsc --noEmitreports no errors in themSKIP=check-copyright-year pre-commit run --all-filespasses🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation