fix(ncp-local-cluster): drop stale local.yaml check from dry tests#310
Open
mesutoezdil wants to merge 1 commit into
Open
fix(ncp-local-cluster): drop stale local.yaml check from dry tests#310mesutoezdil wants to merge 1 commit into
mesutoezdil wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe multicluster Make test no longer validates an ChangesMulticluster Make test
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sbaum1994
approved these changes
Jul 21, 2026
mesutoezdil
force-pushed
the
mesutoezdil/fix/multicluster-test-stale-check
branch
from
July 21, 2026 17:51
c4dac02 to
1c86ebf
Compare
test-multicluster-make failed on main because it grepped deploy/stacks/self-managed/environments/local.yaml, a file that has never existed in this repo. Environment files other than base.yaml are created by users per the local development docs. Remove the stale check so the dry tests pass again. Closes NVIDIA#307 Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
mesutoezdil/fix/multicluster-test-stale-check
branch
from
July 21, 2026 18:28
1c86ebf to
7fd060e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
make test-multicluster-make fails on main because it greps deploy/stacks/self-managed/environments/local.yaml, a file that has never existed in this repo; env files beyond base.yaml are user-created per the local development docs. Removed the stale check. The target now passes on this branch and still fails on main.
Issues
Closes #307
Summary by CodeRabbit