Skip to content

fix(ncp-local-cluster): drop stale local.yaml check from dry tests#310

Open
mesutoezdil wants to merge 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/fix/multicluster-test-stale-check
Open

fix(ncp-local-cluster): drop stale local.yaml check from dry tests#310
mesutoezdil wants to merge 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/fix/multicluster-test-stale-check

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

TL;DR

make test-multicluster-make fails on main because it greps deploy/stacks/self-managed/environments/local.yaml, a file that has never existed in this repo; env files beyond base.yaml are user-created per the local development docs. Removed the stale check. The target now passes on this branch and still fails on main.

Issues

Closes #307

Summary by CodeRabbit

  • Tests
    • Removed a validation check for the invocation service URL from the local multicluster test.
    • Multicluster testing now proceeds directly to compute control-plane endpoint alias validation.

@mesutoezdil
mesutoezdil requested a review from a team as a code owner July 21, 2026 12:18
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4eb30957-a6e7-4b12-97b9-1666563d7a13

📥 Commits

Reviewing files that changed from the base of the PR and between 1c86ebf and 7fd060e.

📒 Files selected for processing (1)
  • tools/ncp-local-cluster/tests/test-multicluster-make.sh
💤 Files with no reviewable changes (1)
  • tools/ncp-local-cluster/tests/test-multicluster-make.sh

📝 Walkthrough

Walkthrough

The multicluster Make test no longer validates an invocationServiceURL entry in the missing local environment file. Subsequent compute control-plane endpoint alias checks remain unchanged.

Changes

Multicluster Make test

Layer / File(s) Summary
Remove obsolete invocation URL check
tools/ncp-local-cluster/tests/test-multicluster-make.sh
Deletes the assertion for the invocation service DNS endpoint while retaining the following endpoint alias checks.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately describes removing the stale local.yaml check from the multicluster test.
Linked Issues check ✅ Passed The change resolves issue #307 by removing the failing check that referenced the missing local.yaml file.
Out of Scope Changes check ✅ Passed The PR only removes the stale test assertion and introduces no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@mesutoezdil
mesutoezdil force-pushed the mesutoezdil/fix/multicluster-test-stale-check branch from c4dac02 to 1c86ebf Compare July 21, 2026 17:51
test-multicluster-make failed on main because it grepped
deploy/stacks/self-managed/environments/local.yaml, a file that has
never existed in this repo. Environment files other than base.yaml
are created by users per the local development docs. Remove the
stale check so the dry tests pass again.

Closes NVIDIA#307

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the mesutoezdil/fix/multicluster-test-stale-check branch from 1c86ebf to 7fd060e Compare July 21, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ncp-local-cluster: test-multicluster-make fails on main, checks a missing local.yaml

2 participants