Skip to content

fix(ncp-local-cluster): drop stale local.yaml check from dry tests #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mesutoezdil wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −4
Open

fix(ncp-local-cluster): drop stale local.yaml check from dry tests #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tools/ncp-local-cluster/tests/test-multicluster-make.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,6 @@ fi
if ! grep -q '10081:10081' "$ROOT_DIR/k3d-config.yaml"; then
fail "single-cluster k3d config must expose the stack-owned grpc-gw TCP listener on host port 10081"
fi
if ! grep -q 'invocationServiceURL: http://invocation.nvcf.svc.cluster.local:8080' "$ROOT_DIR/../../deploy/stacks/self-managed/environments/local.yaml"; then
fail "local stack values must advertise the invocation service DNS worker endpoint"
fi

if ! grep -q 'service-nvct-api.yaml' "$ROOT_DIR/apps/compute-control-plane-endpoints/kustomization.yaml"; then
fail "compute control-plane endpoint aliases must include the NVCT API Service"
fi
Expand Down