fix(nv-boot): make notice_check_test work in the monorepo layout#324
Merged
Conversation
📝 WalkthroughWalkthroughAdds a Bazel negative-test quarantine entry for ChangesBazel test quarantine
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/bazel-root-test-quarantine.txt:
- Around line 26-34: Update the header of the quarantine file so it no longer
claims all entries belong to nvcf-go or universally track NVIDIA/nvcf#284. Make
the header generic, or move ownership and tracking details into comments
associated with each entry while preserving the nv-boot entry’s NVIDIA/nvcf#323
metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4a2bbad3-b0e9-4e05-9514-e97e7730e16c
📒 Files selected for processing (1)
.github/bazel-root-test-quarantine.txt
The test was written for nv-boot-parent as a standalone workspace root, so it
resolved generate_notice.py and its metadata at ${workspace}/tools/bazel/... and
checked ${workspace}/NOTICE. In the monorepo the workspace root is the repo
root, so those files live under src/libraries/java/nv-boot-parent/tools/bazel and
the import failed (No module named 'generate_notice'); it also checked the
aggregate root NOTICE (Go+Rust+Java) with only nv-boot's Java roots, which can
never match.
Point the script at the subtree prefix and at nv-boot-parent's own NOTICE, and
swap the //:NOTICE data dep for //src/libraries/java/nv-boot-parent:NOTICE. The
Maven lock stays the single root //:maven_install.json (where the Java dep
versions live). This never ran before #311 enabled root tests.
Co-authored-by: Balaji Ganesan <bganesan@nvidia.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
balajinvda
force-pushed
the
fix/quarantine-notice-check
branch
from
July 21, 2026 20:49
f4d7ea0 to
70cf875
Compare
kristinapathak
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The #269 merge turned main red once #311 enabled root tests:
//src/libraries/java/nv-boot-parent/tools/bazel:notice_check_testfailed withNo module named 'generate_notice'. It was written for nv-boot-parent as a standalone workspace root, so it resolved its helper/metadata at${workspace}/tools/bazel/...and checked${workspace}/NOTICE— but in the monorepo the workspace root is the repo root (files live undersrc/libraries/java/nv-boot-parent/...), and${workspace}/NOTICEis the aggregate root NOTICE (Go+Rust+Java) that a Java-only regeneration can never match.What changed (proper fix, not a quarantine)
notice_check_test.sh: resolvegenerate_notice.py, metadata, and roots under thesrc/libraries/java/nv-boot-parentprefix, and check nv-boot-parent's own NOTICE. The Maven lock stays the single root//:maven_install.json.tools/bazel/BUILD.bazel: swap the//:NOTICEdata dep for//src/libraries/java/nv-boot-parent:NOTICE.The test now validates nv-boot-parent's NOTICE (its Java closure) against the root lock, which is what it was designed to do. No quarantine.
Testing
Script passes
bash -n; the root row runs the test (no longer skipped). Green root here confirms the NOTICE is fresh and the test passes.Issues
Closes #323
References
Broke via #269 after #311 enabled root tests.
Dependencies
None