Skip to content

fix(nv-boot): make notice_check_test work in the monorepo layout #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balajinvda merged 1 commit into from
Jul 21, 2026
+13 −6
Merged

fix(nv-boot): make notice_check_test work in the monorepo layout #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/java/nv-boot-parent/tools/bazel/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ sh_test(
":generate_notice.py",
":notice_metadata.json",
"//:MODULE.bazel",
"//:NOTICE",
# nv-boot-parent's own NOTICE (its Java closure), not the aggregate root
# NOTICE which also covers the Go/Rust subtrees and can never match a
# Java-only regeneration.
"//src/libraries/java/nv-boot-parent:NOTICE",
"//:maven_install.json",
":notice_roots.json",
],
Expand Down
14 changes: 9 additions & 5 deletions src/libraries/java/nv-boot-parent/tools/bazel/notice_check_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,12 @@ find_workspace() {
}

workspace="$(find_workspace)"
# nv-boot-parent is a subtree of the monorepo, not the workspace root, so its
# notice tooling and its own NOTICE live under this prefix rather than at the
# repo root. The Maven lock, however, is the single root maven_install.json.
nvboot="${workspace}/src/libraries/java/nv-boot-parent"

PYTHONPATH="${workspace}/tools/bazel" python3 - <<'PY'
PYTHONPATH="${nvboot}/tools/bazel" python3 - <<'PY'
import pathlib
import tempfile
import zipfile
Expand Down Expand Up @@ -96,9 +100,9 @@ with tempfile.TemporaryDirectory() as directory:
raise AssertionError("Runtime NOTICE accepted a stale lockfile version")
PY

exec python3 "${workspace}/tools/bazel/generate_notice.py" \
exec python3 "${nvboot}/tools/bazel/generate_notice.py" \
--maven-install "${workspace}/maven_install.json" \
--metadata "${workspace}/tools/bazel/notice_metadata.json" \
--notice "${workspace}/NOTICE" \
--root-manifest "${workspace}/tools/bazel/notice_roots.json" \
--metadata "${nvboot}/tools/bazel/notice_metadata.json" \
--notice "${nvboot}/NOTICE" \
--root-manifest "${nvboot}/tools/bazel/notice_roots.json" \
--check
Loading