SR.001 returns a list of errors from CheckStage, but the validation framework expects failures to be registered using _AddFailedCheck, as demonstrated by SR.002.
|
errors.extend(self.check_sr001_metadata_whitelist(stage)) |
|
|
|
return errors |
|
self._AddFailedCheck( |
|
requirement=cap.SimReadyRequirements.SR_002, |
|
message=f"No thumbnail found at {thumbnail_path} for SimReady asset <{real_path}>", |
|
at=stage, |
|
) |
As a result, assets with missing required SR.001 metadata pass validation without reporting any failures.
Verified with a stage authoring no customLayerData at all, SR.001 reports no failures.
Expected behavior: CheckStage should register each error returned by check_sr001_metadata_whitelist() using self._AddFailedCheck(...), with requirement=cap.SimReadyRequirements.SR_001, similar to the SR.002 implementation.
Acceptance criteria: An asset missing one or more required metadata fields fails SR.001 validation and reports the corresponding error message.
SR.001 returns a list of errors from CheckStage, but the validation framework expects failures to be registered using _AddFailedCheck, as demonstrated by SR.002.
simready-foundation/nv_core/sr_specs/docs/capabilities/core/sim_ready/validation.py
Lines 45 to 47 in 0ed0dfb
simready-foundation/nv_core/sr_specs/docs/capabilities/core/sim_ready/validation.py
Lines 98 to 102 in 0ed0dfb
As a result, assets with missing required SR.001 metadata pass validation without reporting any failures.
Verified with a stage authoring no customLayerData at all, SR.001 reports no failures.
Expected behavior: CheckStage should register each error returned by check_sr001_metadata_whitelist() using self._AddFailedCheck(...), with requirement=cap.SimReadyRequirements.SR_001, similar to the SR.002 implementation.
Acceptance criteria: An asset missing one or more required metadata fields fails SR.001 validation and reports the corresponding error message.