This repository was archived by the owner on Nov 24, 2020. It is now read-only.
Change log level from error to info on some places#16
Open
diegobernardes wants to merge 1 commit into
Open
Conversation
umatrangolo
suggested changes
Sep 15, 2020
| # Otherwise we blow up the request | ||
| unexpected -> | ||
| Logger.error("auth_middleware error: unexpected response - #{inspect(unexpected)}") | ||
| Logger.info("auth_middleware error: unexpected response - #{inspect(unexpected)}") |
There was a problem hiding this comment.
You did not change the message: error is still there and could be confusing.
| {:more, _body, _downstream} -> | ||
| # TODO this doesn't handle large bodies | ||
| Logger.error("Request body too large! Size was #{:cowboy_req.body_length(downstream)}") | ||
| Logger.info("Request body too large! Size was #{:cowboy_req.body_length(downstream)}") |
There was a problem hiding this comment.
I think this is genuinely an error given that is our fault we can't handle big request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ugo, I changed the log level of these 2 lines from error to info. If you think that we should change more lines, check out the code and search for
Logger.errorbut I think that the remaining ones are really errors.