Skip to content
This repository was archived by the owner on Nov 24, 2020. It is now read-only.

Change log level from error to info on some places #16

Open
diegobernardes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change log level from error to info on some places #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/spacesuit/auth_middleware.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ defmodule Spacesuit.AuthMiddleware do

# Otherwise we blow up the request
unexpected ->
Logger.error("auth_middleware error: unexpected response - #{inspect(unexpected)}")
Logger.info("auth_middleware error: unexpected response - #{inspect(unexpected)}")

@umatrangolo umatrangolo Sep 15, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not change the message: error is still there and could be confusing.

@umatrangolo umatrangolo Sep 15, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use WARN instead ?

error_reply(req, 401, "Bad Authentication Token")
{:stop, req}
end
Expand Down
2 changes: 1 addition & 1 deletion lib/spacesuit/proxy_handler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ defmodule Spacesuit.ProxyHandler do

{:more, _body, _downstream} ->
# TODO this doesn't handle large bodies
Logger.error("Request body too large! Size was #{:cowboy_req.body_length(downstream)}")
Logger.info("Request body too large! Size was #{:cowboy_req.body_length(downstream)}")

@umatrangolo umatrangolo Sep 15, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is genuinely an error given that is our fault we can't handle big request.

end
else
@http_client.request(method, url, ups_headers, [], [])
Expand Down