Repository navigation
fix(release): add Homebrew assets to a release that already exists - #558
Merged
Merged
Conversation
The release docs say either release workflow may create the GitHub release and each adds only its own assets. The Homebrew publish step instead assumed an existing release already held its archive, manifest, and checksums, and failed with "no assets match the file pattern" when the Python SDK workflow had created the release first, as it did for v0.12.0. Mirror the Python SDK step: compare each Homebrew asset the release already has byte for byte, and upload the ones it lacks. Signed-off-by: wchwawa <wch19961116@gmail.com>
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No issue: this is a release-tooling chore, which the template exempts. It blocks the Homebrew half of the 0.12.0 release.
Summary
scripts/release/README.mdsays either release workflow may create the GitHub release, and each adds only its own immutable assets. The Homebrew publish step instead assumed that an existing release already held its archive, manifest, andSHA256SUMS.no assets match the file pattern(run 39564170939), so it skipped the tap update PR.Scope
object-store, agent interface, or docs change is mixed in.
maintenance task this PR resolves (release chore; see above).
Change Size And Review
current-head pusher approved the exact current head commit. Not applicable: under 5,000 lines.
not being used to justify mixed package or lifecycle boundaries.
Code Contract (Code Changes Only)
Claims and Evidence
planned capabilities (no documentation change).
authentication or authorization (no security claims).
run count, and raw-evidence location (no performance claims).
Validation
python3 scripts/release/test_homebrew_source_release.pypasses with the new assertion, and the workflow YAML parses.actionlint, which is not installed locally. The release path itself runs when the workflow is dispatched again for v0.12.0 after this merges.Contributor Sign-off
Signed-off-bytrailer.