the-robots: gate ammo chests, wire the damage vignette, fix chest fallback - #3
Merged
Merged
Conversation
…lback Refs Noisemaker111/jgengine#1346 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the confirmed defects from Noisemaker111/jgengine#1346 in
the-robots.src/game/commands.ts:openAmmoChestnow goes through the sameopenedChestsStoregate as red chests (claimChest); a re-interact showsCHEST EMPTYand grants nothing.src/game/feel.ts,src/loop.ts:notePlayerHealthmarks a hurt when the health stat drops between ticks, soDamageVignetterenders (noteHurtwas never called).src/game/world/models.ts:red_chest.fallbackModel→quaternius-modular-scifi/Prop_Crate4(wasdungeon/chest, not in any declared pack).src/game/items/weapons/catalog.ts: dropped the unusedstarterSmgroll.src/game/loadouts.ts: starter cash 40 → 50 so one Insta-Health (45) is affordable before the first kill. Assumption: a small nudge is enough; adjust if the economy wants otherwise.src/game/commands.test.ts,src/game/feel.test.ts: chests pay out once; health drop marks a hurt, first reading and heals do not.Not changed: the gun viewmodels are already primitive blasters on main (
Viewmodel.tsx), and the unboundedgunRegistry/lastFiredAtmaps are left as-is (pruning needs a liveness rule for rolled guns).Root cause: the ammo chest handler had no once-only gate while the red chest one did; the vignette signal had no producer. Engine side:
pickModelaccepted a deadfallbackModelsilently — a dev warning lands in Noisemaker111/jgengine#1751.Refs Noisemaker111/jgengine#1346
Verification:
bun test src88 pass (against local 0.18.1 packages;bun installin Games fails on@jgengine/navbake404 so the workspace typecheck could not run —tsgoon the game reports only the missingvite/clienttypes).drive --spawn -539,0,531.5 --key KeyEtwice: reserve 80 → 104 and grenades 2 → 3 after the first press only.drive --spawn -57,0,560 --record: health 80 → 0 under the Rusk aura with the vignette visible on hit frames.Before / after (starter cash in the HUD):
Damage vignette, frames from the same clip (no hit in the window / hit):
▶ hurt-clip.mp4 (download to play)
🤖 Generated with Claude Code