Skip to content

check-skill-api orphan gate and shrink-only orphan ratchet are mutually unsatisfiable on main (~63 unbaselined orphans) #893

Description

@Noisemaker111

Problem

check-skill-api cannot go green on main: ~63 exported primitives are orphans (no game adopter, no skill example) and must be baseline-tracked to pass, but check-orphan-ratchet forbids scripts/api-orphan-baseline.json growing beyond origin/main's 358 entries — the two gates are mutually exclusive until the orphans are resolved in code.

Context

  • Found while fixing gate drift in PR ADR 0002 + phase 1: extract gameContext descriptors, baseline serialization ownership; fix gate baseline drift #892; bun run gen:skill-api -- --seed-baseline wants to write 417 orphan entries (vs 358 committed), so seeding breaks the ratchet and reverting breaks the gate.
  • The 63 net-new orphans entered through merged PRs — PR CI runs only the quick job, so the full check-types gate never ran on them.
  • scripts/api-orphan-baseline.json also carries 10 stale entries for primitives since adopted/removed (removals are ratchet-legal).
  • Sanctioned resolutions per CLAUDE.md: surface each primitive in a domain SKILL.md, adopt it in a game, or mark it @internal.

Suggested scope

  1. Dump the 63-orphan list (bun run check-skill-api output) and triage each: @internal for plumbing, skill example for real primitives.
  2. Remove the 10 stale baseline entries (shrink-only, ratchet-legal).
  3. Confirm bun run check-skill-api && bun run check-orphan-ratchet both pass on a clean checkout.
  4. Consider running the full gate (not just quick) in PR CI for packages/* changes so orphans can't land silently again.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions