Author the sky sun by bearing and warn on clipped or crossfaded skies - #1748
Merged
Merged
Conversation
sky({ sun: { azimuth, elevation } }) places the dome glow and sky-owned sun light;
under timeOfDay the day arc swings around that noon position. Unset, the shell
derives it from the first authored directional light so the dome sun agrees with
the shadows. Time-of-day domes now draw the sun disc. Dev warnings once per site
for sky.radius past the camera far plane and for noon-only tints under timeOfDay.
Editor lighting panel gains bearing/height sliders.
Refs #1660
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sky sun authoring plus the two dev warnings from #1660. The dome sun and an authored directional light disagreed on the-robots because the dome glow came from the preset bearing.
packages/core/src/world/features.ts:SkySunConfig(azimuth/elevationdegrees) onsky({ sun }); once-per-site warning whenzenithColor/horizonColorride atimeOfDaycrossfade.packages/core/src/devtools/warnOnce.ts: shared dev-only warn-once helper.packages/shell/src/environment/daylightCycle.ts:sunDirectionFromBearing,bearingFromDirection; the day arc rotates so noon lands on the authored bearing.packages/shell/src/environment/Daylight.tsx: radius-vs-camera-far warning; time-of-day and biome domes now draw the sun disc and track it per frame.packages/shell/src/Shell3dPresentation.tsx: with nosky.sunand a fixed preset, the dome sun is derived from the first authored directional light.sunAzimuth/sunElevationon the scene document, bearing/height sliders inLightingPanel.Closes #1660
Verification:
check-typescore/shell/editor pass;testfeatures, editor, environment, daylightCycle pass;check-stateful-ratchet,check-doc-symbols,check-orphan-ratchet,check-changelogpass.the-robots
--mode play, before (dome sun at the preset bearing, off frame) / after (dome sun derived from the authored directional light):🤖 Generated with Claude Code