Publish navbake with the lockstep set and gate the release list against manifests - #1753
Merged
Merged
Conversation
…st manifests @jgengine/editor@0.18.1 depends on @jgengine/navbake, which no publish list included, so bun install on the released SDK fails. navbake joins the publish workflow, set-version, release bullet, and README set. check-release-set reads the three lists plus package manifests and fails on any unpublished or out-of-order workspace dependency; it runs in gate, check-types, and publish. Closes #1752 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jgengine/editor@0.18.1depends on@jgengine/navbake@^0.18.0, and no publish list included navbake, sobun installon the released SDK 404s. Root cause: three hand-maintained copies of the package set (publish workflow,set-version, release bullet) with nothing checking them against the manifests..github/workflows/publish.yml: navbake in both package loops (after sql, before react);check-release-setruns before build.scripts/set-version.ts,scripts/release.ts,README.md: navbake in the lockstep set.scripts/check-release-set.ts(+ test): every@jgengine/*dependency of a published package must be in the publish list, earlier than its dependent; the three lists must agree. Wired intogate/check-typesviarun-stages.tsandpackage.json.Closes #1752. No version bump here; the next release cut publishes navbake at the lockstep version. Surfaced by two agent runs that could not install a game against 0.18.1.
Verification:
bun run check-release-setpasses on the repo;bun test scripts/check-release-set.test.ts5 pass (including the navbake-missing and out-of-order cases);scripts/release.test.ts4 pass;check-skills,check-changelogpass. No rendered surface, no screenshots.🤖 Generated with Claude Code