Fix cold web build prerequisites - #1757
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1632; other CI repair legs remain open.
Root cause: the web command depended on unbuilt workspace exports; the shared build command now establishes prerequisites and cold PR CI catches regressions.
Verification: cold build reproduced @jgengine/rapier resolution failure before the fix; bun --cwd=apps/web run build PASS afterward (runner, SSR, 18 prerendered pages); bun test apps/web PASS (21 tests); ship:preflight PASS; PR CI PASS, including cold web-build (53s).
Full local gate FAIL: 23 game-feel findings; test:all 7695 pass / 1 skip / 17 fail across unrelated export/packaging, game scanners, scaffold and stale contract assertions. All 23 workspace typechecks passed. Remaining failures stay tracked by #1632.
Screenshots omitted: build orchestration only.