Un-red main: fix orphan-gate false positives, guard degraded generation, surface red main

[Noisemaker111]

Main's checks CI job has been red since the curated-barrels PR (#885) merged, and nobody could see it: PRs run only the quick job, the real gates run post-merge on main where no session listens. Every cloud session since then hit the same wall locally, misread it as its own bug, and burned time re-diagnosing. This PR fixes the failures themselves plus every mechanism that let them merge, hide, and recur — and, after merging today's main back in, all the additional breakage that landed on main while it was red-blind.

The mechanisms (why this kept happening)

1. 31 false orphans — the orphan gate checked each symbol per skill, so barrel re-exports (@jgengine/core/world, core/gameplay) attributed to the main jgengine skill flagged symbols documented in their domain skill, and the shrink-only ratchet made them un-baselinable. This kept check-types red on main.
2. Silent generator corruption — with dist missing (every fresh container), ts-morph silently dropped whole modules, corrupting api.md and baselines with no warning.
3. Rollback of good work — gen-skill-api-safe restored all generated files whenever the inner gate failed, and printed "Pruned N entries" for writes it undid.
4. .test.tsx broke builds — every package's build excludes covered only .test.ts.

Mechanism fixes

• Orphan check unions skill tokens across all skills: a primitive surfaced in any SKILL.md or adopted anywhere passes everywhere; pruned 97 stale baseline entries (shrink-only ratchet passes).
• gen-skill-api hard-fails with a clear message when any extracted package lacks dist.
• Gen mode exits 2 when generation completed but gate failures remain; the safe wrapper keeps valid generated files and only rolls back on real corruption/crash.
• PR quick job now runs bun run build + check-skill-api (merged with main's check-orphan-ratchet addition) so this failure class can't merge unseen again.
• When main's aggregate CI job fails on a push, a step files/updates a "CI red on main" issue — red main becomes a visible signal instead of a tax on the next session.
• All 11 packages' build excludes cover .test.tsx; CLAUDE.md/AGENTS.md updated and resynced.

Red-main fallout fixed (found by running the full gate on merged main — none of it compiled or passed before)

• core: EditorDocument lacked the catalogs field and ParamSchema import its own editor code referenced (feat(editor): gameplay data catalogs via game-exported ParamSchema #900); three document constructors updated.
• shell: AuthoredScene lost its placeObjects prop/render in the liveDocument refactor (feat(editor): two-way live doc-patch sync (#860) #904) but kept the dangling consts; defineGame loop hooks now satisfy feat(core): defineGame composable systems with per-system scheduling #942's Required<GameLoop> contract.
• editor: missing seedEditorCatalogs/EditorCatalogDefinition/CatalogsPanel imports, undefined catalogById, readonly-array mutation, frozen editor loop missing hooks; cli.ts referenced an undefined variable and never wired in parseEditorCliArgs/loadRpcPayload, leaving --rpc-file/stdin (and their tests) dead — now wired.
• games/apps: claudecraft's headless tests drove the raw loop export while feat(core): defineGame composable systems with per-system scheduling #942 moved combat into systems — now drive the composed loop (7 tests un-failed); apps/dev demos + the-robots updated for the new contracts; tower-guard's editorCatalogs.ts kept at the loader's src/ convention with check-game-shape taught the skeleton file; stale export manifest regenerated; jgengine-gameplay SKILL.md trimmed back under the size ratchet; retired jgengine-procedural reference removed from the barrel generator and the drifted gameplay barrel regenerated.

Verification

• bun run gate fully green on the merged tree: preflight, every check gate, 4821 tests across 536 files, build.
• Dist guard manually verified (removing a package's dist makes generation refuse loudly).
• Claudecraft failures confirmed pre-existing by running the same tests on clean origin/main before fixing.

Once merged, main's checks job should go green for the first time since #885.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GjYn1uP6nf8maGvAvHFNjB

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
jgengine-web	Ignored	Preview	Jul 16, 2026 10:22pm