Skip to content

build: upgrade revm to v43.0.3 (tag v120) - #1847

Merged
anaPerezGhiglia merged 4 commits into
feat/amsterdam-revm-upgradefrom
build/upgrade-revm-43
Oct 22, 2026
Merged

anaPerezGhiglia merged 4 commits into
feat/amsterdam-revm-upgradefrom
build/upgrade-revm-43

Conversation

@anaPerezGhiglia

@anaPerezGhiglia anaPerezGhiglia commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Targets the feat/amsterdam-revm-upgrade feature branch, not main: op-revm is pinned to a commit of the optimism monorepo's develop that no op-reth release contains yet.

Changes

  • Upgrades all revm workspace dependencies to the versions at revm tag v120 (revm 43.0.3).
  • op-revm: new snapshot of the NomicFoundation/op-revm mirror at df7168ef, the squash commit of optimism#23046 (merged into develop on 2026-10-16), the first monorepo commit on revm 43; pinned by rev until an op-reth release contains it.
  • foundry-fork-db: git pin on the foundry-core revision Foundry v1.8.5 ships with; no crates.io release supports revm 43.
  • revm-inspectors 0.44 adds four TracingInspectorConfig knobs; they are set to keep the previous tracing behavior, as in foundry#17073
  • Amsterdam integration tests re-baselined to revm's devnet-8 schedule (details below). No EDR logic changed.
  • No public API changes.

Dependency changes

Crate Old New
revm, revm-handler, revm-inspector, revm-precompile, revm-context 42.0.1 / 42.0.0 43.0.3
revm-context-interface, revm-interpreter 42.0.0 43.0.2
revm-database-interface, revm-state 42.0.0 43.0.1
revm-primitives, revm-bytecode 42.0.0 43.0.0
op-revm mirror tag op-reth-v2.6.0-da6d325 mirror rev 5a0d3e50 (monorepo df7168ef, revm 43.0.2)
revm-inspectors 0.42.2 0.44.1
foundry-fork-db foundry-core@78e5b57 foundry-core@39c03a49 (0.27.0 on revm 43.0.3)
c-kzg 2.1.8 unchanged
Why these op-revm and fork-db pins

op-revm

  • crates.io: op-revm 20.0.0 pins revm ^38, no release supports revm 43.
  • The latest op-reth release, v2.6.0, is on revm 42.0.1.
  • The revm 43 bump is optimism#23046, squash-merged into develop as df7168ef (rust/Cargo.toml#L435: revm = "43.0.2").
  • Mirror commit 5a0d3e50 snapshots rust/op-revm at df7168ef; verification per the mirror's PROVENANCE.md.
  • Pinned by rev because no op-reth release contains df7168ef yet; the pin moves to a mirror tag once one does.

fork-db

  • crates.io: foundry-fork-db 0.27.0 pins revm ^41, no release supports revm 43.
  • Foundry v1.8.5, the latest stable release, pins foundry-fork-db to foundry-core revision 39c03a49.
  • At that revision crates/fork-db/Cargo.toml#L36 depends on revm 43.
  • EDR impact: BlockchainDbMeta gained an AccountFetchPolicy field (serde(default), existing caches load); BlockchainDbMeta::new selects Auto, which is the behavior fork-db already had. Only a test literal in backend/mod.rs changed.
Amsterdam gas numbers shift

revm v116+ applies the Glamsterdam devnet-8 schedule at Amsterdam. Three integration tests were re-baselined; every value reproduces from revm's constants or the gas the EVM charged:

Test Change
eip2780.rs TRANSFER_LOG_COST was folded into TX_VALUE_COST upstream; the local sum constant is gone, assertions use TX_VALUE_COST
eip7981.rs EIP-8038 access-list item costs: address 3,000 → 2,900, storage key 3,000 → 2,000 (cold access less the warm access still charged at first use)
eip8037.rs rejects_transaction_exceeding_remaining_execution_gas test parameters adjusted since the cold SLOAD cost dropped (3,000 → 2,100)

Follow-ups

  • Bump revm-inspectors to 0.44.2 once cooldown window is done.
  • Re-pin op-revm to a mirror tag once an op-reth release contains df7168ef.

@anaPerezGhiglia anaPerezGhiglia added the no changeset needed This PR doesn't require a changeset label Oct 16, 2026
@anaPerezGhiglia anaPerezGhiglia changed the title build: upgrade revm 43 build: upgrade revm to v43 Oct 16, 2026
@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 23cd740

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The core execution-engine upgrade and unreleased op-revm pin require human confirmation of runtime compatibility and integration results.

0 open findings

What changed in this PR

Upgrades the EVM dependency stack to revm 43, targeting a feature branch because op-revm uses an unreleased commit.

Changes:

  • Updates dependency versions, Git pins, and lockfile.
  • Adapts tracing configuration and backend test metadata to updated APIs.
  • Adjusts integration-test gas expectations.
File Description
crates/​foundry/​evm/​traces/​src/​lib.rs Adds tracing configuration and test fields.
crates/​foundry/​evm/​core/​src/​backend/​mod.rs Sets account-fetch policy in test metadata.
crates/​edr_provider/​tests/​integration/​eip8037.rs Adjusts execution-gas rejection test limit.
crates/​edr_provider/​tests/​integration/​eip7981.rs Updates access-list gas costs.
crates/​edr_provider/​tests/​integration/​eip2780.rs Uses the consolidated value-transfer charge.
Cargo.toml Upgrades revm and compatible dependencies.
Cargo.lock Records updated dependency resolutions.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@anaPerezGhiglia anaPerezGhiglia changed the title build: upgrade revm to v43 build: upgrade revm to v43.0.3 (tag v120) Oct 16, 2026
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.02%. Comparing base (a05a1c2) to head (23cd740).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/amsterdam-revm-upgrade    #1847   +/-   ##
============================================================
  Coverage                        81.02%   81.02%           
============================================================
  Files                              474      474           
  Lines                            84016    84026   +10     
  Branches                         84016    84026   +10     
============================================================
+ Hits                             68072    68083   +11     
+ Misses                           13661    13660    -1     
  Partials                          2283     2283           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 16, 2026 15:52 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 16, 2026 15:52 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 16, 2026 18:05 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 16, 2026 18:08 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 16, 2026 18:08 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia marked this pull request as ready for review October 16, 2026 19:10
@anaPerezGhiglia
anaPerezGhiglia requested a review from a team October 16, 2026 19:10
@Wodann
Wodann requested review from Wodann and removed request for a team October 19, 2026 16:33

@Wodann Wodann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with some small changes:

  • verbose_raw_tracing uses TracingInspectorConfig::all(), which now also enables record_bytecode and record_step_deltas. Consider .set_bytecode(false).set_step_deltas(false) on that path

Worth a mention in the PR description or even a changeset:

  • Amsterdam debug_trace* structlogs now carry stateGasCost and stateGasReservoir. Pre-Amsterdam output is unchanged.
  • revm 43 also moves ACCOUNT_WRITE to 9,000 and CREATE_ACCESS to 12,000, drops the value charge for creates, and reworks selfdestruct finalization from Cancun. All covered by CI.

Comment thread Cargo.lock Outdated
[[package]]
name = "revm-inspectors"
version = "0.42.2"
version = "0.44.1"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The dependency table says revm-inspectors 0.44.2, but Cargo.toml and Cargo.lock have 0.44.1.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, I forgot to update the table. Thanks for the catch. Last week cargo cooldown would fail on revm-inspectors 0.44.2, so I manually downgraded it to 0.44.1. That's why I left a follow-up action "Bump revm-inspectors to 0.44.2 once cooldown window is done.". I can bump it again to 0.44.2 now

@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 20, 2026 23:01 — with GitHub Actions Inactive
@anaPerezGhiglia

Copy link
Copy Markdown
Contributor Author

Thanks for the verbose_raw_tracing catch @Wodann! I applied your suggestion and disabled bytecode and step-delta recording. I also fixed the description table of revm-inspectors to 0.44.1 until the cooldown passes.

Regarding the debug_trace* struct-log fields and the repricing changes, I was planning on addressing them in follow-up PRs that review each affected EIP and add changesets where they apply. The in-place selfdestruct finalization from 43.0.0 was reverted by revm in 43.0.1 (bluealloy/revm#3887), so at the pinned version it is unchanged from revm 42.

@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 20, 2026 23:06 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 14:55 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 15:23 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia merged commit 84f8ebd into feat/amsterdam-revm-upgrade Oct 22, 2026
64 of 66 checks passed
@anaPerezGhiglia
anaPerezGhiglia deleted the build/upgrade-revm-43 branch October 22, 2026 16:17

This branch was successfully deployed

No deployments
github-action-benchmark — 23cd740a Deployed Oct 22, 2026 by anaPerezGhiglia via Run JS Solidity test runner benchmark #5889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed This PR doesn't require a changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants