Repository navigation
build: upgrade revm to v43.0.3 (tag v120) - #1847
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
95bf0f9 to
95908d9
Compare
|
There was a problem hiding this comment.
🔵 Needs a closer look
The core execution-engine upgrade and unreleased op-revm pin require human confirmation of runtime compatibility and integration results.
0 open findings
What changed in this PR
Upgrades the EVM dependency stack to revm 43, targeting a feature branch because op-revm uses an unreleased commit.
Changes:
- Updates dependency versions, Git pins, and lockfile.
- Adapts tracing configuration and backend test metadata to updated APIs.
- Adjusts integration-test gas expectations.
| File | Description |
|---|---|
| crates/foundry/evm/traces/src/lib.rs | Adds tracing configuration and test fields. |
| crates/foundry/evm/core/src/backend/mod.rs | Sets account-fetch policy in test metadata. |
| crates/edr_provider/tests/integration/eip8037.rs | Adjusts execution-gas rejection test limit. |
| crates/edr_provider/tests/integration/eip7981.rs | Updates access-list gas costs. |
| crates/edr_provider/tests/integration/eip2780.rs | Uses the consolidated value-transfer charge. |
| Cargo.toml | Upgrades revm and compatible dependencies. |
| Cargo.lock | Records updated dependency resolutions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/amsterdam-revm-upgrade #1847 +/- ##
============================================================
Coverage 81.02% 81.02%
============================================================
Files 474 474
Lines 84016 84026 +10
Branches 84016 84026 +10
============================================================
+ Hits 68072 68083 +11
+ Misses 13661 13660 -1
Partials 2283 2283 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Wodann
left a comment
There was a problem hiding this comment.
Approve with some small changes:
verbose_raw_tracingusesTracingInspectorConfig::all(), which now also enablesrecord_bytecodeandrecord_step_deltas. Consider.set_bytecode(false).set_step_deltas(false)on that path
Worth a mention in the PR description or even a changeset:
- Amsterdam
debug_trace*structlogs now carrystateGasCostandstateGasReservoir. Pre-Amsterdam output is unchanged. - revm 43 also moves
ACCOUNT_WRITEto 9,000 andCREATE_ACCESSto 12,000, drops the value charge for creates, and reworks selfdestruct finalization from Cancun. All covered by CI.
| [[package]] | ||
| name = "revm-inspectors" | ||
| version = "0.42.2" | ||
| version = "0.44.1" |
There was a problem hiding this comment.
nit: The dependency table says revm-inspectors 0.44.2, but Cargo.toml and Cargo.lock have 0.44.1.
There was a problem hiding this comment.
oh yes, I forgot to update the table. Thanks for the catch. Last week cargo cooldown would fail on revm-inspectors 0.44.2, so I manually downgraded it to 0.44.1. That's why I left a follow-up action "Bump revm-inspectors to 0.44.2 once cooldown window is done.". I can bump it again to 0.44.2 now
|
Thanks for the Regarding the |
0c0df76 to
23cd740
Compare
84f8ebd
into
feat/amsterdam-revm-upgrade
feat/amsterdam-revm-upgradefeature branch, notmain:op-revmis pinned to a commit of the optimism monorepo'sdevelopthat no op-reth release contains yet.Changes
revmworkspace dependencies to the versions at revm tagv120(revm43.0.3).op-revm: new snapshot of the NomicFoundation/op-revm mirror atdf7168ef, the squash commit of optimism#23046 (merged intodevelopon 2026-10-16), the first monorepo commit on revm 43; pinned byrevuntil an op-reth release contains it.foundry-fork-db: git pin on thefoundry-corerevision Foundry v1.8.5 ships with; no crates.io release supports revm 43.revm-inspectors0.44 adds fourTracingInspectorConfigknobs; they are set to keep the previous tracing behavior, as in foundry#17073Dependency changes
op-reth-v2.6.0-da6d3255a0d3e50(monorepodf7168ef, revm 43.0.2)foundry-core@78e5b57foundry-core@39c03a49(0.27.0 on revm 43.0.3)Why these op-revm and fork-db pins
op-revm
developasdf7168ef(rust/Cargo.toml#L435:revm = "43.0.2").5a0d3e50snapshotsrust/op-revmatdf7168ef; verification per the mirror'sPROVENANCE.md.revbecause no op-reth release containsdf7168efyet; the pin moves to a mirror tag once one does.fork-db
foundry-fork-dbtofoundry-corerevision39c03a49.crates/fork-db/Cargo.toml#L36depends on revm 43.BlockchainDbMetagained anAccountFetchPolicyfield (serde(default), existing caches load);BlockchainDbMeta::newselectsAuto, which is the behavior fork-db already had. Only a test literal inbackend/mod.rschanged.Amsterdam gas numbers shift
revm v116+ applies the Glamsterdam devnet-8 schedule at Amsterdam. Three integration tests were re-baselined; every value reproduces from revm's constants or the gas the EVM charged:
eip2780.rsTRANSFER_LOG_COSTwas folded intoTX_VALUE_COSTupstream; the local sum constant is gone, assertions useTX_VALUE_COSTeip7981.rseip8037.rsrejects_transaction_exceeding_remaining_execution_gasSLOADcost dropped (3,000 → 2,100)Follow-ups
revm-inspectorsto0.44.2once cooldown window is done.op-revmto a mirror tag once an op-reth release containsdf7168ef.